General-legendary-salary: fix linting

[clottman]

tl;dr: Things in this PR:

• clean up the Popover component
• new linting configuration that will catch more errors
• fixes for things the new linting configuration complained about
• fix for runtime console warning from Icon component due to recently updated search Icon
• update eslint & its friends
• turns on dogfood of server-side linting on Glitch

Why did this happen

The linting configuration we were previously using in shared components either excludes some important rules, or was failing silently. I learned this because I shipped a version of shared-components that has a bug that the linter should have caught.

I wasn't excited about playing whack-a-mole to figure out additional useful rules that weren't included in eslint-config-react-app, so instead I switched the config to extending eslint:recommended, plugin:jsx-a11y/recommended, and plugin:react/recommended. This is more in line with what the community site does for linting. (The community site also adds the airbnb eslint config, which is more opinionated.)

Popover bug

Linting fixes revealed a bug! This is the dream of linters everywhere.

edited to say:
I was largely wrong about there being a bug in the Popover component; we were passing one prop to something that was just a styled div that didn't take props, which I thought was a bug affecting behavior, but it was not affecting behavior at all. (see edit history of this description for more details on what I was thinking)
resume non-edited content

Also, since the Popover story example was using startOpen=true, when you load shared-components.glitch.me, the Delete Team element that is the popover example immediately receives focus. In addition to fixing the bug, the example now has startOpen={false} so you can load shared-components.glitch.me and see the top of the page.

Linting fixes for new rules

• Many display names were added
  • see slack message for details on why that's awesome
  • I did not add a display name, and instead ignored the error temporarily, if the component being complained about was only used in a Story and nowhere else
• a bunch of variables were defined but never used, so the variables got removed

Server side linting

Got instructions from Osmose on enabling server-side linting in the glitch editor. It appears to be working!

• this requires using .eslintrc.json, not .eslintrc.js.
• this means we can see errors from our plugins (React & jsx-a11y) in the glitch editor!
• there will be a slight delay when you start editing your first javascript file before the errors start showing up
• other weird things might happen; this is experimental

[whimsicallyson]

Popover from shared-components is already in use in a few places in community, but we don't use the startOpen prop in any of those instances.

we should be using it in user-options-pop (ln 166). does this change mean it works now, or is there a change we need to do on the community side to get it functioning properly?

[whimsicallyson]

I'm a bit worried about this... since most popovers shouldn't startOpen. If this starts working as intended, will we suddenly have an open popover nightmare site?

Granted that's also something we can probably test locally before updating the package version in prod, right?

[clottman]

Updated to remove my introduction of a bug-fix-that-doesn't-fix-anything-but-maybe-breaks-stuff in the Popover component.

I thought we were using the community-specific Popover in user-options-pop in Community, but @whimsicallyson pointed out I was wrong on that. We were passing in startOpen as always true to PopoverContainer - but that's fine, because PopoverContainer is just a styled div, which doesn't read that prop at all. So, I removed startOpen from PopoverContainer inside Popover, but left everything else alone.

Still working on testing these changes- the instructions in contributing.md aren't working for me :(

[whimsicallyson]

addressed all my concerns! let me know if you want any 🦆for trying to get it working locally, I haven't tried but am happy to bounce ideas off

[clottman]

@whimsicallyson and I both tested this as a pre-release on staging; it works! Deploying now

[keithk]

🚀 PR was released in v0.19.0 🚀