This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Add Editor icons and adjust default icon size #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./.glitch-assets:252452/2220 ./lib/icon.js:252452/693
./.glitch-assets:252452/2208 ./lib/icon.js:252452/676
./lib/icon.js:252452/458 ./.glitch-assets:252452/1505
./.glitch-assets:252452/707 ./lib/icon.js:252452/224
./watch.json:252452/26 ./lib/icon.js:252452/2
./lib/icon.js:252452/12
./lib/animation-container.js:252452/2
./.glitch-assets:252452/4117
…o atlantic-spot
sheridanvk
commented
Jan 9, 2020
| {"name":"mouse.png","date":"2019-09-10T14:07:50.101Z","url":"https://cdn.glitch.com/3e774f68-7017-4c21-bced-dc0e98e90643%2Fmouse.png","type":"image/png","size":2214,"imageWidth":32,"imageHeight":32,"thumbnail":"https://cdn.glitch.com/3e774f68-7017-4c21-bced-dc0e98e90643%2Fmouse.png","thumbnailWidth":32,"thumbnailHeight":32,"uuid":"n48qBPsfGdKgWFTM"} | ||
| {"name":"party.png","date":"2019-09-18T14:12:56.192Z","url":"https://cdn.glitch.com/967447b4-a24e-4bae-80e4-3aee75414e03%2Fparty.png","type":"image/png","size":840,"imageWidth":32,"imageHeight":32,"thumbnail":"https://cdn.glitch.com/967447b4-a24e-4bae-80e4-3aee75414e03%2Fparty.png","thumbnailWidth":32,"thumbnailHeight":32,"uuid":"TWHdhjQQDEgfyFmG"} | ||
| {"name":"handshake.png","date":"2019-09-18T14:12:56.216Z","url":"https://cdn.glitch.com/967447b4-a24e-4bae-80e4-3aee75414e03%2Fhandshake.png","type":"image/png","size":388,"imageWidth":32,"imageHeight":32,"thumbnail":"https://cdn.glitch.com/967447b4-a24e-4bae-80e4-3aee75414e03%2Fhandshake.png","thumbnailWidth":32,"thumbnailHeight":32,"uuid":"TT0ywpqxKZe7TjvN"} | ||
| <<<<<<< HEAD |
Contributor
Author
There was a problem hiding this comment.
Seems like this came in from an old merge conflict, so I removed it
sheridanvk
requested review from
a team,
clottman and
sarahzinger
and removed request for
clottman and
sarahzinger
ehmorris
approved these changes
Jan 9, 2020
Contributor
ehmorris
left a comment
ehmorris
left a comment
There was a problem hiding this comment.
Size change sounds good to me. I also double checked all the new urls.
Contributor
|
all makes sense to me! are you good to deploy and update the module, or would you like a buddy? |
Contributor
Author
|
thank you! will give it a go tomorrow and let you know if I have any issues
:)
…On Thu, Jan 9, 2020 at 4:18 PM Allyson ***@***.***> wrote:
all makes sense to me! are you good to deploy and update the module, or
would you like a buddy?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#75>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACLFWLBHJOUHIPCEUV6TAP3Q4452XANCNFSM4KDFTKMA>
.
|
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the icons we need to use the shared Icon component in the editor, and adjusts the default size of the icon to 1em. The Community site has overridden the size of the icon to match this new default size already, so this will allow us to remove those overrides.
Icons were added to https://shared-components.glitch.me/#StoryIcon
Remix for testing: https://atlantic-spot.glitch.me/#StoryIcon