Ajar math: a couple of styling updates #74
Conversation
./lib/popover.js:9/15 ./lib/block.js:9/2
./changelog.md:9/86
|
|
||
| --- | ||
|
|
||
| ## [0.13.10] - 2019-12-17 |
There was a problem hiding this comment.
btw i think we probably want to hold off on publishing/changelog changes until after a pr is approved yeah? otherwise we can get into a merge conflict here
There was a problem hiding this comment.
let me know how the docs go for ya, I'm sure I missed things 😭
lib/popover.js
Outdated
| const PopoverWrap = styled.div` | ||
| position: absolute; | ||
| width: auto; | ||
| width: max-content; |
There was a problem hiding this comment.
This may break popovers in IE/Edge since this value isn't supported in those browsers.
There was a problem hiding this comment.
ugh I can't believe I didn't check that 🤦♀ let me double check that it does in fact work better than auto, and if so we can poke at it further!
There was a problem hiding this comment.
ok, the one place I'm currently finding an issue is team-user-pop. possibilities:
as current:
max-content:
I think what would work is to make it so that if a Button has an Icon, make it so that there isn't a break between the text and the image. We can't do white-space: nowrap on the Button though, we had that in the past: #40
Thoughts?
There was a problem hiding this comment.
I see. I thought that adding a min-width to popovers was a way to fix this (the editor has static width popovers), but that would break the tiny pops that we use for collection options. In the editor, we override the pop width in cases like the file options pop.
Maybe text-wrapping could be changed from the default, to an option that's false by default. I think most of our buttons are only a few words anyways. We could toggled the text-wrap on in specific cases where we know we're using really long copy — plus, using really long copy should probably be avoided.
./lib/button.js:9/163
./lib/button.js:9/731
./lib/button.js:9/79
./lib/popover.js:9/15
ehmorris
left a comment
ehmorris
left a comment
There was a problem hiding this comment.
Changes look good to me
./changelog.md:9/68
./changelog.md:9/30
|
🚀 PR was released in |
4 participants
updates to styling: they were already being globally overwritten on the community site, so I figured I might as well add them here instead.
@FogCreek/design see any reason not to go for this?
@sarahzinger I can test out your new documentation/flow with this release!