This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Some publish script changes and updated contributing documentation #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithk
reviewed
Dec 13, 2019
Contributor
keithk
left a comment
keithk
left a comment
There was a problem hiding this comment.
These all look good to me, I'm going to do a fresh run through of all the instructions to make sure it feels clear as I'm doing it (and it has been ages since I've walked through it) and will report back!
clottman
reviewed
Dec 13, 2019
sarahzinger
changed the title
whimsicallyson
approved these changes
Dec 19, 2019
sarahzinger
force-pushed
the
documentation
branch
from
12bc506 to
007f532
Compare
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still needs to be fully QA'd but I think this is an improvement? I was more hopeful that we'd have better ways to test a WIP version of shared-components in community, but this invalid hooks error was kind of a pain. Feel free to share feedback, I'm sure this isn't 💯 and I'm probably missing easier ways to do things/explain things/etc.
Also I'd like to confirm my changes to the publish script. In my mind this makes sense but I also don't want to test it by publishing unnecessary versions if I can help it, so please check my logic at least :)