This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Sparkly dichondra: Set Max-Width on Pop-overs #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2019 16:16
./lib/block.js:867163/17 ./lib/popover.js:867163/120 ./watch.json:867163/26
sarahzinger
reviewed
Dec 5, 2019
| "include": ["^package\\.json$", "^\\.env$"] | ||
| }, | ||
| "restart": { | ||
| "exclude": ["^lib/"], |
Contributor
Author
There was a problem hiding this comment.
yeah per this conversation: https://fogcreek.slack.com/archives/CJ1G77E87/p1575562388019200
Contributor
There was a problem hiding this comment.
We talked about in #pod-shared-components. Without this line, you have to run refresh to see any changes you make. I'm not sure why it was there in the first place.
sarahzinger
approved these changes
Dec 5, 2019
Contributor
sarahzinger
left a comment
sarahzinger
left a comment
There was a problem hiding this comment.
makes sense to me :) I think we might want to do a fair bit of qa once we merge this change into community since I think there's a lot of manual editing of popover widths now 😭
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should prevent very wide pop-overs such as
Also removed extraneous padding on popover titles.