This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Rich-red: make navigation usable when dev tools is open, and add links to popover/overlay blocks #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 5, 2019 23:31
./lib/block.js:708175/25
./lib/stories.js:708175/179
./lib/popover.js:708175/21
./lib/popover.js:708175/82 ./lib/overlay.js:708175/109
ehmorris
approved these changes
Nov 7, 2019
Contributor
ehmorris
left a comment
ehmorris
left a comment
There was a problem hiding this comment.
Looks good. I just noticed this today!
ttseng
reviewed
Nov 7, 2019
lib/stories.js
Outdated
| height: calc(100% - 10.5rem); | ||
| top: 1em; | ||
| height: calc(100vh - 1em); | ||
| overflow: scroll; |
Contributor
There was a problem hiding this comment.
should we use overflow: auto here instead of scroll so that the scrollbars aren't visible unless they're needed?
ttseng
suggested changes
Nov 7, 2019
Contributor
ttseng
left a comment
ttseng
left a comment
There was a problem hiding this comment.
looks great! just added a few css recommendations.
lib/stories.js
Outdated
| position: sticky; | ||
| top: 10.5rem; | ||
| height: calc(100% - 10.5rem); | ||
| top: 1em; |
Contributor
There was a problem hiding this comment.
I'd suggest top: 5em so that the title of the page Glitch Shared Components has more prominence than the nav
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
Old
New
