Skip to content
This repository was archived by the owner on Jan 22, 2026. It is now read-only.

Added Emoji Instructions & Coffin Emoji #63

Merged
ttseng merged 2 commits into from
Nov 5, 2019
Merged

Added Emoji Instructions & Coffin Emoji #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c698d0b
updated contributing doc to include instructions for adding new emoji…
Nov 5, 2019
e67b849
fixed typo in contributing doc
Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ This guide is written for Glitch team members making changes to our shared-compo

Create a remix of shared-components ([remix link](https://glitch.com/edit/#!/remix/shared-components)) and make all your changes within the remix

### Adding Emojis

All emoji assets live directly in the shared-components app's .glitch-assets. To add a new emoji:
1. Make sure that Tiff or Edwin have approved it first
2. Resize and scale the emoji bitmap. All emojis should be 64x64 pngs that have been compressed using [Pngyu](https://nukesaq88.github.io/Pngyu/). Each image should be on the order of <~5kb in size.
3. Upload the image directly to [shared-component](https://glitch.com/edit/#!/shared-components) .glitch-assets (NOTE: the image is uploaded to shared-components, not your remix!)
4. In your remix, add the emoji alphabetically to `icons` in [icon.js](https://glitch.com/edit/#!/plump-chime?path=lib/icon.js:162:15). The name should match that on [emojipedia](https://emojipedia.org/) and uses camelCase when needed.
5. Follow the rest of the steps below to finish submitting your PR.

### PR Workflow

Create a PR by using the `setup.sh` script (`my-remix` is a placeholder for your remix name):
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ In production applications, you will likely want to use the following babel plug
## Development
This package also renders its own documentation and development environment.

**TODO** explain how glitch remix / pull request flow works, use docs from community site
For more on making changes to shared-components, refer to [CONTRIBUTING.md](https://glitch.com/edit/#!/shared-components?path=CONTRIBUTING.md:1:0)

### Remote components
While you are building or updating a component in this library, you may wish to see it in the context of your application. This package exports the helper `createRemoteComponent` that loads a development version of the library from a URL. For example:
Expand Down
1 change: 1 addition & 0 deletions lib/icon.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ const icons = {
bouquet: 'https://cdn.glitch.com/e7e23ba6-c0ec-4a5a-8dcf-b6f61984cea8%2Fbouquet.png?v=1568142111689',
carpStreamer: 'https://cdn.glitch.com/e7e23ba6-c0ec-4a5a-8dcf-b6f61984cea8%2Fcarp_streamer.png?v=1568142111776',
clapper: 'https://cdn.glitch.com/e7e23ba6-c0ec-4a5a-8dcf-b6f61984cea8%2Fclapper.png?v=1568142111883',
coffin: 'https://cdn.glitch.com/d7f4f279-e13b-4330-8422-00b2d9211424%2Fcoffin.png?v=1572970796613',
creditCard: 'https://cdn.glitch.com/e7e23ba6-c0ec-4a5a-8dcf-b6f61984cea8%2Fcredit_card.png?v=1568142111994',
crystalBall: 'https://cdn.glitch.com/e7e23ba6-c0ec-4a5a-8dcf-b6f61984cea8%2Fcrystal_ball.png?v=1568142112091',
diamondSmall: 'https://cdn.glitch.com/e7e23ba6-c0ec-4a5a-8dcf-b6f61984cea8%2Fdiamond_small.svg?v=1568142112219',
Expand Down