This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Use transient prop to avoid passing fallback to underlying div
#142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the recent upgrade to a newer version of
styled-componentswe've been seeing the error (labeled a warning, but counted as an error in the developer tools) below on all page loads, due to the tooltip component'sfallbackprop.Warning: Received `false` for a non-boolean attribute `fallback`.The problem is that when we pass the
fallbackattribute to thestyled.div, it's giving that attribute to thedivitself, which isn't a valid attribute. I'm not entirely sure why the warning claims that it's not a bool, because the fallback prop in the outer component is a boolean, but regardless, using a "transient prop" for the styled div fixes the problem when I use this canary build in the community repo.📦 Published PR as canary version:
0.22.4--canary.142.351ff43.0✨ Test out this PR locally via:
npm install @glitchdotcom/shared-components@0.22.4--canary.142.351ff43.0 # or yarn add @glitchdotcom/shared-components@0.22.4--canary.142.351ff43.0