This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Add show prop to VisuallyHidden.
#116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahzinger
approved these changes
Jul 8, 2020
| <CodeExample>{`<VisuallyHidden>hidden text</VisuallyHidden>`}</CodeExample> | ||
| <div> | ||
| <p> | ||
| This paragraph contains <VisuallyHidden>(Bruce Willis was dead the whole time)</VisuallyHidden> a secret message. |
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Uptime Limits UI changes include showing buttons on the app dashboard on hover, replacing the date column contents. For accessibility we want the per-row buttons to always be available to screen readers as well.
React doesn't make it easy to sometimes wrap an element with another element (you have to have an extra variable containing either the wrapper or React.Fragment based on a variable). Adding a prop that can control whether the styles are actually applied or not seemed like a better solution.