This repository was archived by the owner on Jan 22, 2026. It is now read-only.
EditableProjectDomain and a backarrow #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clottman
suggested changes
Apr 23, 2020
lib/editable-project-domain.js
Outdated
| - expects to be within external state that can be updated with onChange and onBlur: | ||
| - onChange should be used to persist changes everytime the user types (also potentially updating the url in the browser so as to more gracefully handle refreshes) | ||
| - onBlur should be used to update state globally (no need to cause global rerenders until we're ready) | ||
| - as with all optimisticTextInputs if an error is hit in the onchange or onblur, it'll show a default error state (right now that's a little firetruck) |
Contributor
There was a problem hiding this comment.
We should add this part about errors to the Story - usually when I (and presumably others) are looking for docs, I go straight to the glitch.me/rendered stories page and not the code unless I really need to dig deep.
Contributor
Author
There was a problem hiding this comment.
it's in the story, I made a button to fake an error, is there more that you would want to see?
Contributor
There was a problem hiding this comment.
Ah just the comment, in words, that that error that you can fake was surfaced through the onchange or onblur functions and not some other method (like an onError thing like I was initially thinking)
| const BackArrow = ({ ...props }) => ( | ||
| <SVGBase viewBox="0 0 17 19" {...props}> | ||
| <path fillRule="evenodd" clipRule="evenodd" d="M5.46967 0.469727L0.46967 5.46973C0.176777 5.76262 0.176777 6.23749 0.46967 6.53039L5.46967 11.5304L6.53033 10.4697L2.81068 6.75008H2.82047H2.83928H2.85815H2.87708H2.89607H2.91512H2.93423H2.9534H2.97263H2.99191H3.01125H3.03065H3.0501H3.06961H3.08917H3.10878H3.12845H3.14817H3.16795H3.18777H3.20765H3.22758H3.24755H3.26758H3.28765H3.30777H3.32794H3.34816H3.36842H3.38873H3.40909H3.42949H3.44993H3.47041H3.49094H3.51151H3.53213H3.55278H3.57347H3.59421H3.61498H3.63579H3.65664H3.67753H3.69846H3.71942H3.74042H3.76145H3.78252H3.80362H3.82475H3.84592H3.86712H3.88835H3.90961H3.93091H3.95223H3.97359H3.99497H4.01638H4.03782H4.05928H4.08077H4.10229H4.12383H4.1454H4.16699H4.18861H4.21025H4.23191H4.25359H4.2753H4.29702H4.31877H4.34054H4.36232H4.38412H4.40594H4.42778H4.44963H4.47151H4.49339H4.51529H4.53721H4.55914H4.58108H4.60303H4.625H4.64698H4.66897H4.69097H4.71298H4.73499H4.75702H4.77906H4.8011H4.82315H4.8452H4.86726H4.88933H4.9114H4.93347H4.95555H4.97763H4.99971H5.0218H5.04388H5.06597H5.08805H5.11014H5.13222H5.1543H5.17638H5.19845H5.22053H5.24259H5.26466H5.28671H5.30877H5.33081H5.35285H5.37488H5.3969H5.41891H5.44092H5.46291H5.48489H5.50686H5.52882H5.55077H5.5727H5.59462H5.61653H5.63842H5.6603H5.68216H5.704H5.72583H5.74764H5.76943H5.7912H5.81296H5.83469H5.8564H5.8781H5.89977H5.92141H5.94304H5.96464H5.98622H6.00777H6.0293H6.0508H6.07227H6.09372H6.11514H6.13654H6.1579H6.17924H6.20054H6.22182H6.24306H6.26427H6.28545H6.3066H6.32772H6.3488H6.36984H6.39085H6.41183H6.43277H6.45367H6.47453H6.49536H6.51615H6.5369H6.55761H6.57828H6.59891H6.61949H6.64004H6.66054H6.681H6.70142H6.72179H6.74211H6.76239H6.78263H6.80282H6.82296H6.84305H6.86309H6.88309H6.90304H6.92293H6.94278H6.96257H6.98231H7.002H7.02164H7.04122H7.06075H7.08022H7.09964H7.119H7.13831H7.15756H7.17675H7.19588H7.21495H7.23397H7.25292H7.27181H7.29065H7.30942H7.32812H7.34677H7.36535H7.38387H7.40232H7.42071H7.43903H7.45729H7.47548H7.4936H7.51165H7.52963H7.54755H7.56539H7.58317H7.60087H7.6185H7.63606H7.65354H7.67096H7.6883H7.70556H7.72275H7.73986H7.7569H7.77386H7.79074H7.80755H7.82427H7.84092H7.85749H7.87398H7.89038H7.9067H7.92295H7.93911H7.95518H7.97117H7.98708H8.00291H8.01864H8.03429H8.04986H8.06533H8.08072H8.09602H8.11124H8.12636H8.14139H8.15633H8.17118H8.18593H8.2006H8.21517H8.22965H8.24403H8.25832H8.27251H8.28661H8.30061H8.31451H8.32832H8.34202H8.35563H8.36914H8.38255H8.39586H8.40906H8.42217H8.43517H8.44807H8.46086H8.47355H8.48614H8.49862H8.51099H8.52326H8.53542H8.54748H8.55942H8.57126H8.58298H8.5946H8.60611H8.6175H8.62879H8.63996H8.65102H8.66196H8.67279H8.68351H8.69411H8.70459H8.71496H8.72521H8.73535H8.74536H8.75526H8.76504H8.77469H8.78423H8.79365H8.80294H8.81211H8.82116H8.83009H8.83889H8.84757H8.85612H8.86455H8.87285H8.88102H8.88907H8.89699H8.90478H8.91244H8.91997H8.92737H8.93464H8.94177H8.94878H8.95565H8.96239H8.969H8.97547H8.98181H8.98801H8.99407H9C9.49332 6.75008 11.0971 6.75554 12.5607 7.43105C13.2806 7.76331 13.9433 8.24763 14.4282 8.95525C14.9099 9.65834 15.25 10.631 15.25 12.0001C15.25 13.3692 14.9099 14.3418 14.4282 15.0449C13.9433 15.7525 13.2806 16.2368 12.5607 16.5691C11.0971 17.2446 9.49332 17.2501 9 17.2501H8.99414H8.98828H8.98242H8.97656H8.9707H8.96485H8.95899H8.95313H8.94727H8.94141H8.93556H8.9297H8.92384H8.91799H8.91213H8.90628H8.90043H8.89458H8.88872H8.88287H8.87702H8.87117H8.86532H8.85948H8.85363H8.84779H8.84194H8.8361H8.83026H8.82442H8.81858H8.81274H8.80691H8.80107H8.79524H8.78941H8.78358H8.77775H8.77193H8.7661H8.76028H8.75446H8.74864H8.74282H8.73701H8.73119H8.72538H8.71957H8.71377H8.70796H8.70216H8.69636H8.69056H8.68477H8.67897H8.67318H8.6674H8.66161H8.65583H8.65005H8.64427H8.63849H8.63272H8.62695H8.62119H8.61542H8.60966H8.6039H8.59815H8.5924H8.58665H8.58091H8.57516H8.56943H8.56369H8.55796H8.55223H8.5465H8.54078H8.53506H8.52935H8.52364H8.51793H8.51223H8.50653H8.50083H8.49514H8.48945H8.48377H8.47809H8.47241H8.46674H8.46107H8.45541H8.44975H8.44409H8.43844H8.43279H8.42715H8.42151H8.41588H8.41025H8.40463H8.39901H8.39339H8.38778H8.38217H8.37657H8.37098H8.36539H8.3598H8.35422H8.34864H8.34307H8.3375H8.33194H8.32639H8.32084H8.31529H8.30975H8.30421H8.29869H8.29316H8.28764H8.28213H8.27662H8.27112H8.26562H8.26013H8.25465H8.24917H8.2437H8.23823H8.23277H8.22732H8.22187H8.21642H8.21099H8.20556H8.20013H8.19471H8.1893H8.1839H8.1785H8.1731H8.16772H8.16234H8.15697H8.1516H8.14624H8.14089H8.13554H8.1302H8.12487H8.11954H8.11422H8.10891H8.10361H8.09831H8.09302H8.08773H8.08246H8.07719H8.07193H8.06667H8.06142H8.05619H8.05095H8.04573H8.04051H8.0353H8.0301H8.02491H8.01972H8.01454H8.00937H8.00421H7.99905H7.9939H7.98876H7.98363H7.97851H7.9734H7.96829H7.96319H7.9581H7.95302H7.94794H7.94288H7.93782H7.93277H7.92773H7.9227H7.91768H7.91267H7.90766H7.90267H7.89768H7.8927H7.88773H7.88277H7.87782H7.87287H7.86794H7.86302H7.8581H7.85319H7.8483H7.84341H7.83853H7.83366H7.8288H7.82395H7.81911H7.81428H7.80946H7.80465H7.79985H7.79505H7.79027H7.7855H7.78074H7.77598H7.77124H7.76651H7.76178H7.75707H7.75237H7.74768H7.74299H7.73832H7.73366H7.72901H7.72437H7.71974H7.71512H7.71051H7.70591H7.70132H7.69675H7.69218H7.68762H7.68308H7.67855H7.67402H7.66951H7.66501H7.66052H7.65604H7.65157H7.64711H7.64267H7.63824H7.63381H7.6294H7.625H7.62061H7.61623H7.61187H7.60751H7.60317H7.59884H7.59452H7.59021H7.58592H7.58163H7.57736H7.5731H7.56885H7.56462H7.56039H7.55618H7.55198H7.5478H7.54362H7.53946H7.53531H7.53117H7.52704H7.52293H7.51883H7.51474H7.51067H7.5066H7.50255H7.49852H7.49449H7.49048H7.48648H7.48249H7.47852H7.47456H7.47061H7.46668H7.46276H7.45885H7.45496H7.45108H7.44721H7.44335H7.43951H7.43568H7.43187H7.42807H7.42428H7.42051H7.41675H7.413H7.40927H7.40555H7.40185H7.39816H7.39448H7.39082H7.38717H7.38354H7.37992H7.37631H7.37272H7.36914H7.36558H7.36203H7.35849H7.35497H7.35147H7.34798H7.3445H7.34104H7.33759H7.33416H7.33074H7.32734H7.32395H7.32058H7.31722H7.31387H7.31054H7.30723H7.30393H7.30065H7.29738H7.29413H7.29089H7.28767H7.28446H7.28127H7.2781H7.27494H7.27179H7.26866H7.26555H7.26245H7.25937H7.2563H7.25325H7.25022H7.2472H7.2442H7.24121H7.23824H7.23528H7.23235H7.22942H7.22652H7.22363H7.22076H7.2179H7.21506H7.21223H7.20943H7.20663H7.20386H7.2011H7.19836H7.19564H7.19293H7.19024H7.18756H7.18491H7.18227H7.17964H7.17704H7.17445H7.17188H7.16932H7.16678H7.16426H7.16176H7.15927H7.1568H7.15435H7.15192H7.1495H7.14711H7.14473H7.14236H7.14002H7.13769H7.13538H7.13309H7.13081H7.12856H7.12632H7.1241H7.1219H7.11971H7.11755H7.1154H7.11327H7.11116H7.10907H7.10699H7.10493H7.1029H7.10088H7.09888H7.0969H7.09493H7.09299H7.09106H7.08915H7.08727H7.0854H7.08355H7.08171H7.0799H7.07811H7.07633H7.07458H7.07284H7.07113H7.06943H7.06775H7.06609H7.06445H7.06283H7.06123H7.05965H7.05809H7.05655H7.05502H7.05352H7.05204H7.05057H7.04913H7.04771H7.04631H7.04492H7.04356H7.04222H7.04089H7.03959H7.03831H7.03704H7.0358H7.03458H7.03338H7.0322H7.03104H7.0299H7.02878H7.02768H7.0266H7.02554H7.02451H7.02349H7.0225H7.02152H7.02057H7.01964H7.01872H7.01783H7.01696H7.01612H7.01529H7.01448H7.0137H7.01294H7.01219H7.01147H7.01078H7.0101H7.00944H7.00881H7.0082H7.00761H7.00704H7.00649H7.00596H7.00546H7.00498H7.00452H7.00408H7.00366H7.00327H7.0029H7.00255H7.00222H7.00192H7.00164H7.00137H7.00114H7.00092H7.00073H7.00056H7.00041H7.00029H7.00018H7.0001H7.00005H7.00001L7 18.0001L7.00001 18.7501H7.00005H7.0001H7.00018H7.00029H7.00041H7.00056H7.00073H7.00092H7.00114H7.00137H7.00164H7.00192H7.00222H7.00255H7.0029H7.00327H7.00366H7.00408H7.00452H7.00498H7.00546H7.00596H7.00649H7.00704H7.00761H7.0082H7.00881H7.00944H7.0101H7.01078H7.01147H7.01219H7.01294H7.0137H7.01448H7.01529H7.01612H7.01696H7.01783H7.01872H7.01964H7.02057H7.02152H7.0225H7.02349H7.02451H7.02554H7.0266H7.02768H7.02878H7.0299H7.03104H7.0322H7.03338H7.03458H7.0358H7.03704H7.03831H7.03959H7.04089H7.04222H7.04356H7.04492H7.04631H7.04771H7.04913H7.05057H7.05204H7.05352H7.05502H7.05655H7.05809H7.05965H7.06123H7.06283H7.06445H7.06609H7.06775H7.06943H7.07113H7.07284H7.07458H7.07633H7.07811H7.0799H7.08171H7.08355H7.0854H7.08727H7.08915H7.09106H7.09299H7.09493H7.0969H7.09888H7.10088H7.1029H7.10493H7.10699H7.10907H7.11116H7.11327H7.1154H7.11755H7.11971H7.1219H7.1241H7.12632H7.12856H7.13081H7.13309H7.13538H7.13769H7.14002H7.14236H7.14473H7.14711H7.1495H7.15192H7.15435H7.1568H7.15927H7.16176H7.16426H7.16678H7.16932H7.17188H7.17445H7.17704H7.17964H7.18227H7.18491H7.18756H7.19024H7.19293H7.19564H7.19836H7.2011H7.20386H7.20663H7.20943H7.21223H7.21506H7.2179H7.22076H7.22363H7.22652H7.22942H7.23235H7.23528H7.23824H7.24121H7.2442H7.2472H7.25022H7.25325H7.2563H7.25937H7.26245H7.26555H7.26866H7.27179H7.27494H7.2781H7.28127H7.28446H7.28767H7.29089H7.29413H7.29738H7.30065H7.30393H7.30723H7.31054H7.31387H7.31722H7.32058H7.32395H7.32734H7.33074H7.33416H7.33759H7.34104H7.3445H7.34798H7.35147H7.35497H7.35849H7.36203H7.36558H7.36914H7.37272H7.37631H7.37992H7.38354H7.38717H7.39082H7.39448H7.39816H7.40185H7.40555H7.40927H7.413H7.41675H7.42051H7.42428H7.42807H7.43187H7.43568H7.43951H7.44335H7.44721H7.45108H7.45496H7.45885H7.46276H7.46668H7.47061H7.47456H7.47852H7.48249H7.48648H7.49048H7.49449H7.49852H7.50255H7.5066H7.51067H7.51474H7.51883H7.52293H7.52704H7.53117H7.53531H7.53946H7.54362H7.5478H7.55198H7.55618H7.56039H7.56462H7.56885H7.5731H7.57736H7.58163H7.58592H7.59021H7.59452H7.59884H7.60317H7.60751H7.61187H7.61623H7.62061H7.625H7.6294H7.63381H7.63824H7.64267H7.64711H7.65157H7.65604H7.66052H7.66501H7.66951H7.67402H7.67855H7.68308H7.68762H7.69218H7.69675H7.70132H7.70591H7.71051H7.71512H7.71974H7.72437H7.72901H7.73366H7.73832H7.74299H7.74768H7.75237H7.75707H7.76178H7.76651H7.77124H7.77598H7.78074H7.7855H7.79027H7.79505H7.79985H7.80465H7.80946H7.81428H7.81911H7.82395H7.8288H7.83366H7.83853H7.84341H7.8483H7.85319H7.8581H7.86302H7.86794H7.87287H7.87782H7.88277H7.88773H7.8927H7.89768H7.90267H7.90766H7.91267H7.91768H7.9227H7.92773H7.93277H7.93782H7.94288H7.94794H7.95302H7.9581H7.96319H7.96829H7.9734H7.97851H7.98363H7.98876H7.9939H7.99905H8.00421H8.00937H8.01454H8.01972H8.02491H8.0301H8.0353H8.04051H8.04573H8.05095H8.05619H8.06142H8.06667H8.07193H8.07719H8.08246H8.08773H8.09302H8.09831H8.10361H8.10891H8.11422H8.11954H8.12487H8.1302H8.13554H8.14089H8.14624H8.1516H8.15697H8.16234H8.16772H8.1731H8.1785H8.1839H8.1893H8.19471H8.20013H8.20556H8.21099H8.21642H8.22187H8.22732H8.23277H8.23823H8.2437H8.24917H8.25465H8.26013H8.26562H8.27112H8.27662H8.28213H8.28764H8.29316H8.29869H8.30421H8.30975H8.31529H8.32084H8.32639H8.33194H8.3375H8.34307H8.34864H8.35422H8.3598H8.36539H8.37098H8.37657H8.38217H8.38778H8.39339H8.39901H8.40463H8.41025H8.41588H8.42151H8.42715H8.43279H8.43844H8.44409H8.44975H8.45541H8.46107H8.46674H8.47241H8.47809H8.48377H8.48945H8.49514H8.50083H8.50653H8.51223H8.51793H8.52364H8.52935H8.53506H8.54078H8.5465H8.55223H8.55796H8.56369H8.56943H8.57516H8.58091H8.58665H8.5924H8.59815H8.6039H8.60966H8.61542H8.62119H8.62695H8.63272H8.63849H8.64427H8.65005H8.65583H8.66161H8.6674H8.67318H8.67897H8.68477H8.69056H8.69636H8.70216H8.70796H8.71377H8.71957H8.72538H8.73119H8.73701H8.74282H8.74864H8.75446H8.76028H8.7661H8.77193H8.77775H8.78358H8.78941H8.79524H8.80107H8.80691H8.81274H8.81858H8.82442H8.83026H8.8361H8.84194H8.84779H8.85363H8.85948H8.86532H8.87117H8.87702H8.88287H8.88872H8.89458H8.90043H8.90628H8.91213H8.91799H8.92384H8.9297H8.93556H8.94141H8.94727H8.95313H8.95899H8.96485H8.9707H8.97656H8.98242H8.98828H8.99414H9H9.00994C9.53106 18.7501 11.4144 18.7502 13.1893 17.931C14.0944 17.5133 14.9942 16.8726 15.6656 15.8928C16.3401 14.9083 16.75 13.631 16.75 12.0001C16.75 10.3692 16.3401 9.09182 15.6656 8.10741C14.9942 7.12753 14.0944 6.48685 13.1893 6.06911C11.4144 5.24991 9.53106 5.25004 9.00994 5.25008L9 5.25008H8.99407H8.98801H8.98181H8.97547H8.969H8.96239H8.95565H8.94878H8.94177H8.93464H8.92737H8.91997H8.91244H8.90478H8.89699H8.88907H8.88102H8.87285H8.86455H8.85612H8.84757H8.83889H8.83009H8.82116H8.81211H8.80294H8.79365H8.78423H8.77469H8.76504H8.75526H8.74536H8.73535H8.72521H8.71496H8.70459H8.69411H8.68351H8.67279H8.66196H8.65102H8.63996H8.62879H8.6175H8.60611H8.5946H8.58298H8.57126H8.55942H8.54748H8.53542H8.52326H8.51099H8.49862H8.48614H8.47355H8.46086H8.44807H8.43517H8.42217H8.40906H8.39586H8.38255H8.36914H8.35563H8.34202H8.32832H8.31451H8.30061H8.28661H8.27251H8.25832H8.24403H8.22965H8.21517H8.2006H8.18593H8.17118H8.15633H8.14139H8.12636H8.11124H8.09602H8.08072H8.06533H8.04986H8.03429H8.01864H8.00291H7.98708H7.97117H7.95518H7.93911H7.92295H7.9067H7.89038H7.87398H7.85749H7.84092H7.82427H7.80755H7.79074H7.77386H7.7569H7.73986H7.72275H7.70556H7.6883H7.67096H7.65354H7.63606H7.6185H7.60087H7.58317H7.56539H7.54755H7.52963H7.51165H7.4936H7.47548H7.45729H7.43903H7.42071H7.40232H7.38387H7.36535H7.34677H7.32812H7.30942H7.29065H7.27181H7.25292H7.23397H7.21495H7.19588H7.17675H7.15756H7.13831H7.119H7.09964H7.08022H7.06075H7.04122H7.02164H7.002H6.98231H6.96257H6.94278H6.92293H6.90304H6.88309H6.86309H6.84305H6.82296H6.80282H6.78263H6.76239H6.74211H6.72179H6.70142H6.681H6.66054H6.64004H6.61949H6.59891H6.57828H6.55761H6.5369H6.51615H6.49536H6.47453H6.45367H6.43277H6.41183H6.39085H6.36984H6.3488H6.32772H6.3066H6.28545H6.26427H6.24306H6.22182H6.20054H6.17924H6.1579H6.13654H6.11514H6.09372H6.07227H6.0508H6.0293H6.00777H5.98622H5.96464H5.94304H5.92141H5.89977H5.8781H5.8564H5.83469H5.81296H5.7912H5.76943H5.74764H5.72583H5.704H5.68216H5.6603H5.63842H5.61653H5.59462H5.5727H5.55077H5.52882H5.50686H5.48489H5.46291H5.44092H5.41891H5.3969H5.37488H5.35285H5.33081H5.30877H5.28671H5.26466H5.24259H5.22053H5.19845H5.17638H5.1543H5.13222H5.11014H5.08805H5.06597H5.04388H5.0218H4.99971H4.97763H4.95555H4.93347H4.9114H4.88933H4.86726H4.8452H4.82315H4.8011H4.77906H4.75702H4.73499H4.71298H4.69097H4.66897H4.64698H4.625H4.60303H4.58108H4.55914H4.53721H4.51529H4.49339H4.47151H4.44963H4.42778H4.40594H4.38412H4.36232H4.34054H4.31877H4.29702H4.2753H4.25359H4.23191H4.21025H4.18861H4.16699H4.1454H4.12383H4.10229H4.08077H4.05928H4.03782H4.01638H3.99497H3.97359H3.95223H3.93091H3.90961H3.88835H3.86712H3.84592H3.82475H3.80362H3.78252H3.76145H3.74042H3.71942H3.69846H3.67753H3.65664H3.63579H3.61498H3.59421H3.57347H3.55278H3.53213H3.51151H3.49094H3.47041H3.44993H3.42949H3.40909H3.38873H3.36842H3.34816H3.32794H3.30777H3.28765H3.26758H3.24755H3.22758H3.20765H3.18777H3.16795H3.14817H3.12845H3.10878H3.08917H3.06961H3.0501H3.03065H3.01125H2.99191H2.97263H2.9534H2.93423H2.91512H2.89607H2.87708H2.85815H2.83928H2.82047H2.81064L6.53033 1.53039L5.46967 0.469727Z" fill="#222222" /> | ||
| </SVGBase> |
Contributor
There was a problem hiding this comment.
fill should be a color variable here - fill="var(--colors-primary) would probably work? Other components do fill="currentColor".
This is necessary because the editor has dark mode, so #222 makes sense in light mode but will be invisible in dark mode. The var(--colors-primary) value will be #222 in light mode but the opposite in dark mode, as set by a theme provider component.
Contributor
Author
There was a problem hiding this comment.
great call out thanks!
clottman
approved these changes
Apr 23, 2020
Contributor
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used in https://github.com/glitchdotcom/Glitch-Community/pull/1409