Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alt-text length to be customisable #2737

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nullishamy
Copy link

Closes #2689

I do not have the resources to test this, but I have followed the same procedure as the toot length customisation, so I do not see why it would not work.

Copy link

@soatok soatok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a sensible and self-contained change. It would be Immediately valuable to many people, too.

@kescherCode
Copy link

kescherCode commented Jul 9, 2024

Oh, good change! This is very close to how it's in Catstodon, so I'll go ahead and approve (as a LGTM) :3

alextecplayz added a commit to VantaInteractive/Social that referenced this pull request Aug 12, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Copy link

This pull request has resolved merge conflicts and is ready for review.

@sneakers-the-rat
Copy link

I like this change a lot, and have proposed something similar on our instance before glitch switched to the new way of serving the max_characters config (though some people said it might be undesirable, as it encourages alt text to be overlong. I disagree, but just repeating the discourse).
https://github.com/NeuromatchAcademy/mastodon/pull/16/files

One thing that i would add is that it might be nice to add the default value to the .env.production.sample so people know that this is possible to customize this.

@hackdefendr
Copy link

Last comment was 2 weeks ago. Can we hear from a maintainer on this?

Copy link

@arachnist arachnist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description editor modal for vanilla/non-glitch UI, in app/javascript/mastodon/features/ui/components/focal_point_modal.jsx, should probably be modified as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjustable (increased) character limit for alt text
6 participants