-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alt-text length to be customisable #2737
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a sensible and self-contained change. It would be Immediately valuable to many people, too.
Oh, good change! This is very close to how it's in Catstodon, so I'll go ahead and approve (as a LGTM) :3 |
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has resolved merge conflicts and is ready for review. |
I like this change a lot, and have proposed something similar on our instance before glitch switched to the new way of serving the max_characters config (though some people said it might be undesirable, as it encourages alt text to be overlong. I disagree, but just repeating the discourse). One thing that i would add is that it might be nice to add the default value to the |
Last comment was 2 weeks ago. Can we hear from a maintainer on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description editor modal for vanilla/non-glitch UI, in app/javascript/mastodon/features/ui/components/focal_point_modal.jsx
, should probably be modified as well.
Closes #2689
I do not have the resources to test this, but I have followed the same procedure as the toot length customisation, so I do not see why it would not work.