Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyword mute instrumentation #363

Open
hannahwhy opened this issue Feb 11, 2018 · 2 comments
Open

Keyword mute instrumentation #363

hannahwhy opened this issue Feb 11, 2018 · 2 comments
Labels
enhance feature expansion ft-keyword mute

Comments

@hannahwhy
Copy link
Member

One should be able to see the following information on their keyword mutes:

  1. The most recent match time for each mute.
  2. The last N statuses (N = 50?) that were muted, along with the keyword that triggered the mute.
@hannahwhy
Copy link
Member Author

To get this information, I think we'll have to move from a single regex that matches any muted keyword to one check per keyword. There might be some fancy tricks we can play with regex groups to match a keyword mute to a Glitch::KeywordMute, but I'm not sure said tricks would be worth the cost we'd pay in clarity.

hannahwhy added a commit that referenced this issue Jun 3, 2018
@hannahwhy
keyword mute: Store keywords as a list
37d495e 
This has a couple of advantages over the regex approach:

- Keywords are individually addressable, which makes it easier to gather
  statistics (#363)
- Keywords can be individually applied to different feeds, e.g. skipping
  mentions (#454)

It *does* end up creating many more Regexp objects.  I'm not yet sure if
the difference is significant.
@hannahwhy hannahwhy mentioned this issue Jun 3, 2018
Merged
@hannahwhy
Copy link
Member Author

#530 has been merged, which makes this a lot easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhance feature expansion ft-keyword mute
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannahwhy