Fix IE null value serialization

glimmerjs · Jun 20, 2017 · bb21d74 · bb21d74
1 parent 9c690dd
commit bb21d74
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/@glimmer/runtime/lib/vm/attributes/dynamic.ts b/packages/@glimmer/runtime/lib/vm/attributes/dynamic.ts
@@ -126,13 +126,13 @@ export class SafeDynamicProperty extends DefaultDynamicProperty {
 
 export class InputValueDynamicAttribute extends DefaultDynamicProperty {
   set(dom: ElementBuilder, value: Opaque) {
-    dom.__setProperty('value', normalizeStringValue(value));
+    dom.__setProperty('value', normalizeInputValue(value));
   }
 
   update(value: Opaque) {
     let input = <HTMLInputElement>this.attribute.element;
     let currentValue = input.value;
-    let normalizedValue = normalizeStringValue(value);
+    let normalizedValue = normalizeInputValue(value);
     if (currentValue !== normalizedValue) {
       input.value = normalizedValue!;
     }
@@ -165,6 +165,14 @@ function isUserInputValue(tagName: string, attribute: string) {
   return (tagName === 'INPUT' || tagName === 'TEXTAREA') && attribute === 'value';
 }
 
+function normalizeInputValue(value: Opaque) {
+  if (value === null || value === undefined || typeof value.toString !== 'function') {
+    return '';
+  }
+
+  return `${value}`;
+}
+
 function normalizeStringValue(value: Opaque): Option<string> {
   if (value === false || value === undefined || value === null || typeof value.toString === 'undefined') {
     return null;