build: Replace django-storages master with pjsier:update-azure-storag… #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cooper667
previously approved these changes
Jul 29, 2021
ChasNelson1990
previously approved these changes
Jul 29, 2021
Pipfile
Outdated
| @@ -45,6 +43,8 @@ PyNaCl = "==1.4.0" | |||
| PyYAML = "==5.3.1" | |||
| psycopg2-binary = ">=2.9.1" | |||
| django-apscheduler = ">=0.6.0" | |||
| django-storages = {editable = true, ref = "update-azure-storage", git = "https://github.com/pjsier/django-storages.git"} | |||
There was a problem hiding this comment.
Why are you installing it as editable?
There was a problem hiding this comment.
Also, I think you should be able to specify a commit so that it doesn't get accidentally upgraded?
SilviaZeta
dismissed stale reviews from ChasNelson1990 and cooper667
via
3eda22b
of azure-storage-blob 12.8.1, i think |
ChasNelson1990
approved these changes
Jul 30, 2021
cooper667
approved these changes
Jul 30, 2021
cooper667
pushed a commit
that referenced
this pull request
Aug 16, 2021
#81) * build: Replace django-storages master with pjsier:update-azure-storage branch * fix: Django-storages is editable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Description
Installed django-storages's branch jschneier/django-storages#805 that supports
azure-storage-blobversions >=12.0.0.Dependency changes
django-storages = {version = "==1.11.1", extras = ["azure"]}withdjango-storages = {editable = true, ref = "update-azure-storage", git = "https://github.com/pjsier/django-storages.git"}azure-storage-blobfrom2.1.0to12.8.1Testing
No
Documentation
No
Migrations (if applicable)
Have any database migrations been committed as part of this pull request?
Checklist: