Add SessionPolicyCallback #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #7
Closed
DSpeichert
reviewed
May 13, 2018
|
In general looks good |
|
@progrium assuming I can resolve the merge conflicts, what do you think would block a merge? Happy to dig in and add whats necessary - only thing I can see is probably documentation. |
|
I think nothing would block merge. |
|
ooo.. good to go now? |
josegonzalez
approved these changes
Feb 22, 2019
|
Yep, should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation which could probably use a little more testing. Additionally, any feedback on names and interfaces would be welcome.
Note that I added the lock on the context because it's the only way to guarantee that you can add a value to the context without races, but I'd be open to other options.
Closes #7.
This is also meant as a precursor for #79 since I think the default should not allow a subsystem request to go through.