Grab IP from containers sharing network namespace #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce, such as with Kubernetes pods
arentrue
pushed a commit
to rbkmoney/registrator
that referenced
this pull request
Jan 25, 2017
…ce, such as with Kubernetes pods (gliderlabs#507)
|
Sorry for that @balexx. I have found some workaround for my issue. Thanks for your help so far. |
|
@meganesh What is the workaround? can you please provide some info? |
|
Hi @balexx, Can I know the docker version on your bare metal (where docker container of kubernetes can show their IP Address)? |
|
@meganeshkaila sure, we're currently on 1.12.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes pods create a single container which holds the IP for all other containers in the pod. Thus, when using Registrator, services could appear without an IP address. This PR solves that issue by detecting the namespace is shared, and extracting the IP information from the container holding it.