Use exit status to determine if container was killed #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the "kill" and "stop" events, this uses the exit status to check whether the container was terminated via a signal. This will be more reliable since the "kill" event can also be sent for non-fatal signals such as SIGHUP. Fixes gliderlabs#248
|
@progrium I know we'd talked about this a while ago in light of Docker changing the order of the stop vs. die events, but just wanted a second set of eyes on this before merging. |
|
👍 |
1 similar comment
|
👍 |
|
Pls merge... I need send some signals to containers... |
mgood
added a commit
that referenced
this pull request
Feb 11, 2016
Use exit status to determine if container was killed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the "kill" and "stop" events, this uses the exit status to
check whether the container was terminated via a signal. This will be more
reliable since the "kill" event can also be sent for non-fatal signals such as
SIGHUP.
Fixes #248