Allow env vars in stream URLs #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase and I can merge this in? |
jimmidyson
force-pushed
the
env_vars_in_target
branch
2 times, most recently
from
15da45d to
b06e32e
Compare
|
Hi @progrium - rebased & works still :) |
|
Sorry, rebase again? Major changes just went in. I'll merge quicker this time. |
jimmidyson
force-pushed
the
env_vars_in_target
branch
from
b06e32e to
aa9d2e7
Compare
|
Done - still working :) |
progrium
added a commit
that referenced
this pull request
Mar 24, 2015
Allow env vars in stream URLs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My personal use case for this is to use Kubernetes service env vars to route logs.