fix: typescript types exports #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! Hopefully, they fix the issue with the types ASAP. I was going to start using this library, but then the issue with types stopped me from doing so. |
jtewright
added a commit
to jtewright/glide-data-grid
that referenced
this pull request
Oct 10, 2023
Same as this fix for the core package: glideapps#747
jassmith
pushed a commit
that referenced
this pull request
Nov 26, 2023
Same as this fix for the core package: #747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On node 18 with typescript 5.1.6, the types aren't resolved, this ensure they are picked.
BTW I just found out this incredible project, I'm pretty interested in providing some help on the publish side / ci / qa. Would you be interested ?
Useful tools
Both provides cli tools that can be run locally (ci checks...)