fix: highlight border to be drawn many times in different places in the frozen area #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starlight-93
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where highlight borders are drawn improperly due to multiple cropping regions in frozen areas.
- Introduces calls to ctx.beginPath() and ctx.closePath() for handling the clipping region.
- Aims to address the border rendering by modifying the canvas drawing behavior.
| @@ -117,6 +117,7 @@ export function drawHighlightRings( | |||
| ) { | |||
| const wasDashed: boolean = dashed; | |||
| const needsClip = !rectContains(s.clip, s.rect); | |||
| ctx.beginPath(); | |||
There was a problem hiding this comment.
Using ctx.beginPath() and the later call to ctx.closePath() does not affect the strokeRect call since strokeRect creates its own path. If the intention is to limit the drawing to a specific clipping region, consider calling ctx.clip() after setting the clip rectangle.
Suggested change
| ctx.beginPath(); | |
| // Begin path is unnecessary for strokeRect as it creates its own path |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple cropping regions, resulting in the border not being cropped