Add ability to set scroll behavior when calling ref.scrollTo #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing ref.appendRow
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configurable scroll behavior by introducing a new "behavior" parameter to both the scrollTo and appendRow methods, allowing for smoother transitions when scrolling or appending rows.
- Added an optional "behavior" property to the ImperativeScrollProps interface and updated the examples to demonstrate its usage.
- Modified the DataEditor component to support the new behavior parameter in scrollTo and appendRow methods.
- Updated the API documentation to reflect the new method signatures with behavior options.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/docs/examples/imperative-scroll.stories.tsx | Updated interface and examples to include the new behavior property for scrolling. |
| packages/core/src/data-editor/data-editor.tsx | Modified scrollTo and appendRow functions to accept and propagate the behavior parameter. |
| packages/core/API.md | Revised API documentation to show updated method signatures with behavior options. |
lukasmasuch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature/scroll-behavior
What?
behavioras part of theoptionsobject when callingscrollTomethodbehaviorwhen callingappendRowWhy?
So we can have a smooth transition when programmatically adding a row or scrolling to a given cell.
The current way to do this, as far as I know, is adding a class with
scroll-behavior: smoothto the editor, which causes arrow navigation to also have the smooth behavior which feels awful :/