fix cc9 and cc6 in inconsistency #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glgh
reviewed
May 5, 2017
There was a problem hiding this comment.
Line 180 - this has something to do with unit conversion, using either 10000 or 17000 is fine but results in different cc6 value. Vissim default cc6 = 11.44, the original paper uses cc6 = 6.00. 11.44/17000 roughly equals to 6.00/10000. I think it's consistent here.
Line 183. Again both Vissim and the original paper are correct. Check out the default value: in Vissim: cc8=3.5, cc9=1.5, and we use cc8 - cc9; in original paper cc8=2.0, cc9=1.5, so it's already taken into account.
|
Actually, I just saw the notes you mentioned. Let me double check. |
|
OK, agree with cc6, but cc9 need pre-processed to be a negative value (negative slope), so that line 267 is correct, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.