fix: implement Speakeasy hook to fix multipart file field names #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multipart file field names with Speakeasy SDK hook
Problem
Speakeasy generates incorrect code that adds
"[]"
suffix to file field names in multipart forms:The
"[]"
suffix should only apply to regular form field arrays, not file fields.Solution
Implemented an
SDKInitHook
that patchesserialize_multipart_form
at runtime:"[]"
suffix from file fields only(filename, content, [content_type])
"[]"
suffix for regular form field arraysFiles Changed
src/glean/api_client/_hooks/multipart_fix_hook.py
- Hook implementationsrc/glean/api_client/_hooks/registration.py
- Hook registrationtests/test_multipart_fix_hook.py
- Test coverageTesting
Run
python -m pytest tests/test_multipart_fix_hook.py -v
Notes
forms.py
still contains the original bug