fix: module naming and enable testing #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
speakeasybot
commented
Apr 28, 2025
•
speakeasybot
commented
- The following desirable module naming is now supported:
- Testing has been enabled
speakeasybot
commented
Apr 28, 2025
| @@ -1,5 +1,5 @@ | |||
| [project] | |||
| name = "glean" | |||
| name = "api-client-glean" | |||
speakeasybot
commented
Apr 28, 2025
| @@ -0,0 +1 @@ | |||
| pyproject.toml | |||
There was a problem hiding this comment.
This means we won't automatically re-generate pyproject.toml going forward. This isn't ideal as it could cause unexpected issues however this is what enables us to have the desired package vs module naming in the short term until a generator config feature is exposed.
speakeasybot
commented
Apr 28, 2025
| @@ -94,7 +93,7 @@ sdk = Glean( | |||
|
|
|||
| Once that is saved to a file, you can run it with `uv run script.py` where | |||
| `script.py` can be replaced with the actual file name. | |||
| <!-- End SDK Installation [installation] --> | |||
| <!-- No SDK Installation [installation] --> | |||
There was a problem hiding this comment.
speakeasybot
force-pushed
the
fix/testing
branch
2 times, most recently
from
4fccf3d to
2afe87d
Compare
speakeasybot
changed the title
speakeasybot
changed the title
speakeasybot
changed the title
speakeasybot
force-pushed
the
fix/testing
branch
from
f6b33cd to
c30e331
Compare
SDK Tests Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.