Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headless missing render #152

Closed
valentinedwv opened this issue Feb 6, 2023 · 2 comments
Closed

Headless missing render #152

valentinedwv opened this issue Feb 6, 2023 · 2 comments
Assignees
@fils @valentinedwv
Labels
bug Something isn't working

Comments

@valentinedwv
Copy link
Member

started a branch to help test page rendering. dv_headlessTesting

r2r has two jsonlds, but the second one it not getting captured.

application javascript says it should be in the head

 h.type = "application/ld+json",
        g = f.trustAsHtml(e("json")(g)),
        h.text = g,
        document.querySelector("head").appendChild(h)

in chrome, the jsonld is rendered in the head

In schema validator, it is rendered outside (is it late?)
https://validator.schema.org/#url=https%3A%2F%2Fdev.rvdata.us%2Fsearch%2Ffileset%2F100135

In the headless testing, only find one.

Some discussion here:

@valentinedwv valentinedwv added the bug Something isn't working label Feb 6, 2023
@valentinedwv
Copy link
Member Author

valentinedwv commented Feb 7, 2023 •
edited
Loading

Look at: mafredri/cdp#99 and mafredri/cdp#116

valentinedwv added a commit that referenced this issue Feb 8, 2023
@valentinedwv
Implement headlessWait in the headless Javascript.
a7f9894 
Fixes #152
@valentinedwv valentinedwv mentioned this issue Feb 8, 2023
Merged
valentinedwv added a commit that referenced this issue Feb 8, 2023
@valentinedwv
Implement headlessWait in the headless Javascript.
5f9bcd1 
Fixes #152
add a test that is expected to fail, with 1 JSONld returned.
@valentinedwv
Copy link
Member Author

#127 is resolved by this

valentinedwv added a commit that referenced this issue Mar 6, 2023
@valentinedwv @nein09 @fils
Fix 124 identifiers sha (#135)
5049528 
* run configurations

* adding a uuid command to get uuid for a file sent to stdin.
updated cobra and viper package versions

* Example JSON Paths and arrays of paths


* glcon tool id --idtype indentifiersha --jsonld some file

* test for #129.

* Implemented changes to prevent context mangling

*

* Get things working and DRY code up a bit

* Extract out a constant and a json processing function

* Add test for json finding method

* Test for the api config helper

* Try to make this work for DataStream as well

* Identifiers fix for @graph


* fix wrap in quotes 'script[type="application/ld+json"]'

* add an ideal example resource

* IdentiferPath is a comma separated set of strings, or one string.

* If you are trying not to recorder an array... and copy it, don't use the original later
Clean up LdProc Normalize Tests. Empty triples will be empty triples

* #150 #108
initialize gleaner and nabu configs idependently.

* #145

* added test for a couple of problem children.

* methods to allow dumping data before upload

and glcon tools
jsonld: jsonld > corrected jsonld
rdf: jsonld > rdf

* add a couple resources for cli testing

* Headless rework to make more testable

* Fix Minio connection check error, like was done on nabu

* Implement headlessWait in the headless Javascript.
Fixes #152

* Implement headlessWait in the headless Javascript.
Fixes #152
add a test that is expected to fail, with 1 JSONld returned.

* #155 enable --prefix flag for nabu

* Using c.Page.LoadEventFired to wait for content.
Works. leaving in the headlessWait incase another issue that requires its.

* linux reading of config not working. Updating modules

* Use the config class to read the gleanerConfig.

* Use the config class to read the gleanerConfig.

* Cleaned up tests. Files now used. (#161)

Added ability to just generate a sha of the json.
Was option, but not coded.

* Fix 124 identifiers tests (#162)

* Cleaned up tests. Files now used.
Added ability to just generate a sha of the json.
Was option, but not coded.

* put in approvals into jsonutils

* use log.info not println so this does not show up in console output.

* test for #129.

* Implemented changes to prevent context mangling

* Example JSON Paths and arrays of paths

* clean up some logging CLI.

* glcon tool id --idtype indentifiersha --jsonld some file

* If it's an array, we standardized.
Tests to be sure arrays are not mangled by string
and that strings are not mangled by array.


* IdentiferPath is a comma separated set of strings, or one string.

* methods to allow dumping data before upload
 glcon tools
jsonld: jsonld > corrected jsonld
rdf: jsonld > rdf

Added ability to just generate a sha of the json.
Was option, but not coded.

* Fix 124 identifiers tests (#162)

* put in approvals into jsonutils

* add approval test .approved

* Sort the jsonpath results because UUID generation depends on order of results.


* One more fix for tool id. If no config is passed, just use a generic one.
We need is the contexts, for the triples if it falls through to a normalizedsha
makefile. copy binaries up to that assets are in correct location relative to binaries


---------

Co-authored-by: melinda <melindaminch@oceannetworks.ca>
Co-authored-by: Douglas Fils <drfils@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fils fils

@valentinedwv valentinedwv

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fils @valentinedwv