Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robots.txt not existing for a site is really an error #144

Closed
valentinedwv opened this issue Jan 31, 2023 · 1 comment
Closed

robots.txt not existing for a site is really an error #144

valentinedwv opened this issue Jan 31, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@valentinedwv
Copy link
Member

Is it an actual error when we don't get a robots.txt,
Need to check on other items that may be really info/trace.

{"file":"/github/workspace/internal/summoner/acquire/resources.go:204","func":"github.com/gleanerio/gleaner/internal/summoner/acquire.getRobotsForDomain","level":"error","msg":"error getting robots.txt for https://www.earthcube.org/datasets/allgood:Robots.txt unavailable at https://www.earthcube.org/datasets/allgood/robots.txt","time":"2023-01-30T20:45:53-06:00"}
{"file":"/github/workspace/internal/summoner/acquire/resources.go:66","func":"github.com/gleanerio/gleaner/internal/summoner/acquire.ResourceURLs","level":"error","msg":"Error getting robots.txt for geocodes_demo_datasets, continuing without it.","time":"2023-01-30T20:45:53-06:00"}

@nein09
Copy link
Collaborator

nein09 commented Feb 2, 2023

Yeah, I'd support this moving to 'info', unless the source type is robots.

@valentinedwv valentinedwv added the good first issue Good for newcomers label Feb 5, 2023
valentinedwv added a commit that referenced this issue Mar 20, 2023
#144 Not finding a robots.txt is not an error, just information.
valentinedwv added a commit that referenced this issue Mar 21, 2023
#144 Not finding a robots.txt is not an error, just information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants