Merge pull request #93 from gleamy-js/fix/deployment-issue

chore: add dry-run to the test-phase
gleamy-js · Jul 10, 2024 · 803f0e0 · 803f0e0
2 parents 94600d5 + 6711fd9
commit 803f0e0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.github/workflows/npm-publish-github-packages.yml b/.github/workflows/npm-publish-github-packages.yml
@@ -40,11 +40,11 @@ jobs:
           version: 9.5
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
         env:
+          node-version: ${{ matrix.node-version }}
           NODE_ENV: production
           NODE_AUTH_TOKEN: ${{secrets.NPM_PUBLISH_TOKEN}}
+          registry-url: 'https://registry.npmjs.org'
       - run: pnpm install
       - run: echo "publishing version ${{ env.RELEASE_VERSION }}"
       - run: pnpm version ${{ env.RELEASE_VERSION }}

diff --git a/.github/workflows/test-pull-request.yml b/.github/workflows/test-pull-request.yml
@@ -18,13 +18,18 @@ jobs:
           version: 9.5
       - name: Use Node.js ${{ matrix.node-version }}
         uses: actions/setup-node@v3
-        with:
-          node-version: ${{ matrix.node-version }}
         env:
+          node-version: ${{ matrix.node-version }}
+          registry-url: 'https://registry.npmjs.org'
           NODE_ENV: production
           NODE_AUTH_TOKEN: ${{secrets.NPM_PUBLISH_TOKEN}}
       - run: pnpm install -r
       - run: pnpm run lint
       - run: pnpm run test
       - run: pnpm run build
       - run: pnpm run dry-run
+        env:
+          node-version: ${{ matrix.node-version }}
+          registry-url: 'https://registry.npmjs.org'
+          NODE_ENV: production
+          NODE_AUTH_TOKEN: ${{secrets.NPM_PUBLISH_TOKEN}}