Skip to content

feat: runtime class static keyword#1172

Merged
czosel merged 1 commit into
glayzzle:mainfrom
jorgsowa:feat/runtime-class-static-keyword
Feb 21, 2026
Merged

feat: runtime class static keyword#1172
czosel merged 1 commit into
glayzzle:mainfrom
jorgsowa:feat/runtime-class-static-keyword

Conversation

@jorgsowa

Copy link
Copy Markdown
Collaborator

Fixes: #1135

@jorgsowa

Copy link
Copy Markdown
Collaborator Author

Merged to fork: jorgsowa#6

@jorgsowa jorgsowa closed this Jan 6, 2026
@jorgsowa
jorgsowa deleted the feat/runtime-class-static-keyword branch January 6, 2026 22:10
@czosel

czosel commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

@jorgsowa this change looks great, if you reopen the PR I'd be happy to merge it.

@jorgsowa
jorgsowa restored the feat/runtime-class-static-keyword branch February 19, 2026 14:06
@jorgsowa

jorgsowa commented Feb 19, 2026

Copy link
Copy Markdown
Collaborator Author

No problem. I reopened PR, but I am already using my fork that has many other features/fixes implemented. You can check and you can cherry pick all other commits: https://github.com/jorgsowa/js-php-parser

@jorgsowa jorgsowa reopened this Feb 19, 2026
@alexander-akait

Copy link
Copy Markdown
Collaborator

@czosel To be honestly we can switch from this parser to js-php-parser, more features and better maintenance

@czosel czosel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jorgsowa! I'll go through the other commits and cherry-pick accordingly.

@alexander-akait I admit I didn't give this project enough attention over the past months. Still I think it would be nice to not fork completely yet to try to keep the small community we have together. Maybe @jorgsowa would be interested as coming in as a maintainer?

@czosel
czosel merged commit 31e0894 into glayzzle:main Feb 21, 2026
6 checks passed
@czosel

czosel commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

I published most of the changes in v3.4.0, the property hooks PR (#1143) still needs a closer look to address the comments by @cseufert from code review.

@alexander-akait

Copy link
Copy Markdown
Collaborator

@jorgsowa Yeah, if you interested we can give your right to merge and review and etc, feel free to ping us

@jorgsowa

Copy link
Copy Markdown
Collaborator Author

Sure. I can help you with the maintenance. I forked the repo, because I needed to have version working with PHP 8.4.

@czosel

czosel commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

Awesome! I sent you an invite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Runtime ::class const doesn't work properly

3 participants