Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch macOS to Universal theme #24

Merged
merged 4 commits into from
Aug 23, 2024

Conversation

MikeRatcliffe
Copy link
Collaborator

Fixes #23

@victorwads
Copy link
Collaborator

@MikeRatcliffe i reviwed the PR, its ok.
I will just ask you to add de Version Info on PR, version on Version files and ChangeLog to Version 0.4.0.
(adds a new feature, so incrise middle version)

The Version files are:

  • CMakeList.txt
  • flake.nix
  • macOs/Info.Plist

And Changelog on XML File:

  • io.github.glaumar.QRookie.metainfo.xml

Then i could just Accept your MR and Generate Signed MacOs Versions.

Note: nix build stoped working, but a thing that there is nothing to do with your PR.

@MikeRatcliffe MikeRatcliffe self-assigned this Aug 23, 2024
@victorwads victorwads merged commit 9da2795 into glaumar:main Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS version looks very ugly
2 participants