Specs for PluginFactory #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… specs There has to be this dummy spec, otherwise the HtmlRunner will merely show a blank page - which took me some time to figure out <_<. For this to work you have to manually download and unzip Jasmine in a folder called "jasmine".
|
Added a first real spec for PluginFactory. I gotta say, Jasmine has been a bit underwhelming so far. Its documentation is pretty basic. I had to check the source code in order to learn how to use "toThrow()" for our use case. Anyways, we'll see how this turns out, maybe it's just me... How do we proceed with this PR? Should it be left open until all specs for the PluginFactory are done? |
|
Actually, I'm going to finish this soon, so please leave this PR open. |
|
Ok, that should be it, ready for merging. |
|
👍 awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work you have to manually download and unzip Jasmine (https://github.com/downloads/pivotal/jasmine/jasmine-standalone-1.3.0.zip) in a folder called "jasmine".
Necessary until it's decided which package manager to use that will then install Jasmine.