Skip to content

Conversation

@kosmoz
Copy link
Member

@kosmoz kosmoz commented Sep 9, 2024

@pmig
Copy link
Member

pmig commented Sep 12, 2024

@kosmoz I talked with @robholland about the upstream pr. He is eager to merge it, but as he is traveling it will take at least one more week. In the meantime we should either deploy the helm chart to the glasskube charts repo or build the chart and push it to an oci registry so we are not blocked by the upstream.

@christophenne
Copy link
Contributor

@pmig @kosmoz I think we also need this change in the helm chart: temporalio/helm-charts#550 – Right now, no temporal namespace is created automatically.

@kosmoz
Copy link
Member Author

kosmoz commented Sep 12, 2024

@pmig OK thanks, a version of the chart that includes the TTL and default namespace features is now available on charts.glasskube.eu

@christophenne can you check if the package works for you use case?

Copy link
Contributor

@christophenne christophenne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, when the one type is fixed, it works! 👍

@kosmoz kosmoz marked this pull request as ready for review September 12, 2024 15:15
@kosmoz kosmoz requested a review from pmig as a code owner September 12, 2024 15:15
@pmig pmig requested review from christophenne and pmig and removed request for christophenne September 13, 2024 22:41
pmig
pmig previously approved these changes Sep 13, 2024
kosmoz and others added 12 commits September 13, 2024 15:55
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Signed-off-by: Jakob Steiner <jakob.steiner@glasskube.eu>
Co-authored-by: Christoph Enne <christoph.enne@glasskube.eu>
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
Signed-off-by: Philip Miglinci <pmig@glasskube.eu>
@pmig pmig merged commit 16fc714 into main Sep 13, 2024
@pmig pmig deleted the kosmoz/temporal branch September 13, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants