gh-961: use rng_dispatcher throughout code
#962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
enhancement
Co-authored-by: Connor Aird <c.aird@ucl.ac.uk>
connoraird
approved these changes
Jan 14, 2026
| Use `urng` for array API tests. | ||
| """ | ||
| return np.random.default_rng(seed=SEED) | ||
| return np.random.default_rng(seed=42) |
Contributor
There was a problem hiding this comment.
Can we not use rng_dispatcher here?
Suggested change
| return np.random.default_rng(seed=42) | |
| return _utils.rng_dispatcher(xp=np) |
Member
Author
There was a problem hiding this comment.
So we can, but then the typing becomes UnfiedGenerator rather than np.random.Generator.
Either:
- Doesn't matter and use dispatcher
- Suppress mypy error
What do you think?
Contributor
There was a problem hiding this comment.
Hmm I see. I think I like having the correct type. Could we reuse the seed definition?
Contributor
Member
Author
There was a problem hiding this comment.
So I think let's leave this for now, and fix it once #971 is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The helper function isn't used much and there is duplication. This PR addresses that and also means we don't have to specify the seed in as many places.
Closes: #961
Checks