Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PayPal Subscription #739

Merged
merged 8 commits into from
Dec 5, 2020
Merged

PayPal Subscription #739

merged 8 commits into from
Dec 5, 2020

Conversation

Matt-Lepley
Copy link
Collaborator

Implementation for PayPal subscription

  • Controller and endpoints to handle creating a subscription and unsubscribing
  • Created a "service" to handle the creation of subscriptions and cancelation of them internally and externally. Added documentation and comments stating why I did things this way.
  • paypal-js package for handling PayPal button / subscription call
  • Updated Subscription logic to allow PayPal subscriptions to give the same benefits as a Tier 3 Stripe subscription
  • Subscription view update to include new button and minor display changes
  • Added API keys to ymls

@Matt-Lepley Matt-Lepley self-assigned this Dec 2, 2020
glacials
glacials requested changes Dec 3, 2020
View reviewed changes
Copy link
Owner

@glacials glacials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Overall this code seems well structured, and I agree that for now it's fine to use the existing subscriptions table structure like this. Just a couple of blocking issues for me.

app/javascript/paypal.js Outdated Show resolved Hide resolved
lib/paypal.rb Outdated Show resolved Hide resolved
app/controllers/api/webhooks/paypal_controller.rb Outdated Show resolved Hide resolved
app/views/subscriptions/index.slim Show resolved Hide resolved
BatedUrGonnaDie
BatedUrGonnaDie reviewed Dec 3, 2020
View reviewed changes
Copy link
Collaborator

@BatedUrGonnaDie BatedUrGonnaDie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glacials covered most of what I found, so just 2 small but non-blocking (probably) things from me.

app/javascript/paypal.js Outdated Show resolved Hide resolved
app/javascript/paypal.js Outdated Show resolved Hide resolved
Added webhook for canceling paypal payments via paypal dashboard. Upd…
b6d4818 
…ated namespacing for payments. Added validation when creating a subscription.
glacials
glacials approved these changes Dec 4, 2020
View reviewed changes
Copy link
Owner

@glacials glacials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the code quality, let me know when the bug you mentioned offline is resolved and then I think we're good to go! 🚀

@Matt-Lepley
Copy link
Collaborator Author

I'm happy with the code quality, let me know when the bug you mentioned offline is resolved and then I think we're good to go! 🚀

We are all set, tests on beta went off great. I swapped paypal settings over for live. Last thing is for you to just update the client/secret keys.

@glacials
Copy link
Owner

glacials commented Dec 5, 2020

Awesome -- done and done! Thanks so much Matt :D

@glacials glacials merged commit 5871a05 into main Dec 5, 2020
@glacials glacials deleted the beta branch December 5, 2020 03:36
@Matt-Lepley
Copy link
Collaborator Author

You bet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatedUrGonnaDie BatedUrGonnaDie BatedUrGonnaDie left review comments

@glacials glacials glacials approved these changes

Assignees

@Matt-Lepley Matt-Lepley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matt-Lepley @glacials @BatedUrGonnaDie