Allow trials without credit cards #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently trial subscriptions are handled completely by Stripe, and they don't have an option to allow them without entering payment information first. This branch moves trial subscriptions to be handled by us, so that we don't need to have that requirement in place. It also refactors the code that decides which users have which features, because it was getting pretty muddy having so many features with so many possible grantors of that feature.
BatedUrGonnaDie
requested changes
Nov 26, 2020
glacials
commented
Nov 29, 2020
BatedUrGonnaDie
approved these changes
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently trial subscriptions are handled completely by Stripe, and they don't have an option to allow them without entering payment information first.
This branch moves trial subscriptions to be handled by us, so that we don't need to have that requirement in place.
It also refactors the code that decides which users have which features, because it was getting pretty muddy having so many features with so many possible grantors of that feature. Now, each model that can grant a feature (Subscription, PatreonUser, and now SubscriptionTrial) has the same interface and can be easily queried en masse by User.
Also letting some more
rufolint leak through. I'm pretty confident I want us to switch to it.Fixes #732.