Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap ubuntu back in for alpine #694

Merged
merged 2 commits into from
May 9, 2020
Merged

Swap ubuntu back in for alpine #694

merged 2 commits into from
May 9, 2020

Conversation

BatedUrGonnaDie
Copy link
Collaborator

@BatedUrGonnaDie BatedUrGonnaDie commented May 8, 2020

This should unblock the builds. Requires a pipeline change before merging this in.

I ended up re-using the old splitsio-build code deploy project from before, and modified it with some enhancements we picked up with the alpine builds. Overall we lose a couple of minutes and the container size is a lot larger, but this should solve almost if not all of the compile and dependency issues that we have been seeing with alpine. We also re-unify the dev and prod builds to use the same dockerfile.

@glacials if you can please review this PR, the code deploy project called out, and the beta site briefly to make sure the frontend looks correct. I double checked the JS process.env calls and those look to be good, but I don't know if there are more gotchas in there.

@BatedUrGonnaDie
Copy link
Collaborator Author

Hmm, on the last test it looks like the gem caching portion is still flakey. I've disabled it for the time being so it's not blocking, so builds will be ~2 minutes slower. I plan to take another look at the dependency caching this weekend to hopefully get gem caching reliable and see if I can get node modules working at all.

Copy link
Owner

@glacials glacials left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the CodeBuild project what are the reasons this pull can fail, and what's the effect if we continue anyway?

- docker pull $REPOSITORY_URI:latest || true

Not blocking, everything else looks good! Thanks for taking this over.

@BatedUrGonnaDie
Copy link
Collaborator Author

Some failure reasons: If for some reason it can't connect to ECR (credential issue, connection issue), no image marked as latest, repo doesn't exist.

If there is an error docker will just build the image from scratch. In fact the first time we run each of these build stages this command fails as there is no image in that repo, so it will build it from scratch and then as part of post_build it will tag and upload it for future runs.

@glacials
Copy link
Owner

glacials commented May 8, 2020

Sounds good to me, thanks for explaining!

@BatedUrGonnaDie BatedUrGonnaDie merged commit c0372b4 into master May 9, 2020
@BatedUrGonnaDie BatedUrGonnaDie deleted the beta branch May 9, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants