Upgrade splits.io to rails 6 #529
Conversation
Fixes most of the depreciations notices, tries to standardize most files to what a fresh rails 6 install would like like, toggles most of the 6.0 defaults (excludes backwards incompatible ones), and updates packages and gems accordingly.
|
Is there any chance to get this pushed into the beta pipeline without it being merged into master? Was hoping to make sure some of the changes related to cookies are non-breaking when in production, and it would be nice if they did to be able to easy make changes here so we don't have broken stuff on master. |
There was a problem hiding this comment.
Yeah there's a separate beta-only pipeline that pulls from the beta branch. I'd first delete the existing beta branch (I'm not using it) then replace it with this branch, something like
git push origin --delete beta # replace origin with upstream/glacials/whatever
git checkout -b beta
git push origin headFeel free to push new changes to the beta branch all day, it's safe from hitting production.
| @@ -63,6 +63,10 @@ const uploadAll = function(files) { | |||
|
|
|||
| document.addEventListener('turbolinks:load', function() { | |||
| // Show dropzone-overlay when a file is dragged onto the page | |||
| if (document.getElementById('dropzone') === null) { | |||
| return | |||
| } | |||
There was a problem hiding this comment.
The admin pages. I believe all of the JS changes that aren't directly related to action cable or the changed package names were from that. I saw them when I went checking to make sure they were working properly and noticed them in the console.
| # Mount Action Cable outside main process or domain. | ||
| # config.action_cable.mount_path = nil | ||
| # config.action_cable.url = 'wss://example.com/cable' | ||
| config.action_cable.allowed_request_origins = ['https://splits.io', 'https://*.splits.io'] |
There was a problem hiding this comment.
Do we also need localhost here, or is that implied?
There was a problem hiding this comment.
This one is only for production, which shouldn't need a connection from localhost. In development mode it auto-whitelists localhost.
Fixes most of the depreciations notices, tries to standardize most files to what a fresh rails 6 install would like like, toggles most of the 6.0 defaults (excludes backwards incompatible ones), and updates packages and gems accordingly.