Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix xmlnode data leak in carbons_xml_stripped_cb #42

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Fix xmlnode data leak in carbons_xml_stripped_cb #42

merged 2 commits into from
Oct 23, 2020

Conversation

henry-nicolas
Copy link
Contributor

This fixes a leak highlighted by valgrind

@gkdr gkdr changed the base branch from master to dev October 21, 2020 21:01
gkdr
gkdr reviewed Oct 21, 2020
View reviewed changes
Copy link
Owner

@gkdr gkdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, good find!

src/carbons.c Outdated Show resolved Hide resolved
src/carbons.c Outdated Show resolved Hide resolved
@gkdr gkdr merged commit 03b9d84 into gkdr:dev Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkdr gkdr gkdr left review comments

@EionRobb EionRobb EionRobb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henry-nicolas @EionRobb @gkdr @henry-nicolas2021