Skip to content
This repository was archived by the owner on Aug 21, 2024. It is now read-only.

Allow Jekyll > 4.0 #68

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Allow Jekyll > 4.0 #68

merged 3 commits into from
Mar 24, 2019

Conversation

DirtyF
Copy link
Contributor

@DirtyF DirtyF commented Mar 21, 2019

👋 Hi @gjtorikian

@jekyll/core team bumped jekyll version constraint in jekyll-sitemap:

spec.add_dependency "jekyll", ">= 3.7", "< 5.0"
spec.add_development_dependency "jekyll-last-modified-at", "~> 1.0"

As a result running bundle update will throw a dependency error:

In Gemfile:
    jekyll-last-modified-at (~> 1.0) was resolved to 1.0.0, which depends on
      jekyll (~> 3.2.1)

    jekyll-sitemap was resolved to 1.3.2, which depends on
      jekyll (>= 3.7, < 5.0)

This patch aims to match version constaint on Jekyll, to allow test first v4 alpha.

We're also dropping support for Ruby < 2.4 in Jekyll as 2.3 goes EOL at the end of the month.

Thanks.

@DirtyF DirtyF mentioned this pull request Mar 23, 2019
21 tasks
@gjtorikian
Copy link
Owner

Looks great to me. Thank you for the clear PR! I'll release it as a minor patch bump.

@gjtorikian gjtorikian merged commit b9b1c31 into gjtorikian:master Mar 24, 2019
@DirtyF DirtyF deleted the patch-1 branch March 24, 2019 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants