-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Description lists not working #216
Comments
Ah, comrak calls it definition lists: https://github.com/kivikakk/comrak#extensions I just made the typo here: commonmarker/ext/commonmarker/src/options.rs Lines 100 to 102 in 4663102
Thanks for the report, will fix it soon. |
Ah, actually, I believe this is working as expected. First, MDN calls Second, your markdown has an error: there needs to be a paragraph between the term and its definition:
I'll keep the option name as |
Closing the issues prematurely hints that you are not interested in any input. If I am wasting my time trying to improve this gem, let me know please.
This statement is wrong.
The first 4 references I found: |
You are not wasting your time. Keeping issues open indefinitely stagnates the project. As I have no idea when you'll come back and chastize me or comment or whatever. It helps me know the health of the project: open there's work to do, closed there isn't.
You can find as many references as you want, it doesn't matter if the underlying project (comrak) doesn't support it. From their docs:
Which specs? |
I am assuming the Description Lists extension actually means Definition Lists - I am unable to make it work.
On a side note, perhaps the option key should be renamed to
definition_lists
regardless of how comark calls it?This code does not produce the expected
<dl>
<dt>
tagsOutput:
The text was updated successfully, but these errors were encountered: