Skip to content

Updates to slides#25

Merged
gjbex merged 5 commits into
masterfrom
development
Apr 3, 2025
Merged

Updates to slides#25
gjbex merged 5 commits into
masterfrom
development

Conversation

@gjbex

@gjbex gjbex commented Apr 3, 2025

Copy link
Copy Markdown
Owner

Summary by Sourcery

Update performance measurements and add additional benchmarking for NumPy I/O operations

Enhancements:

  • Added performance measurements for np.load and np.fromfile methods
  • Updated existing performance timings for various NumPy I/O operations

Documentation:

  • Added markdown sections for np.load and np.fromfile methods to provide context for performance measurements

np.int no longer exists, so replaced by np.int8
In the past, you had to import scipy subpackages before you could use them.  This is no longer required, so slides have
been modified accordingly.
@sourcery-ai

sourcery-ai Bot commented Apr 3, 2025

Copy link
Copy Markdown

Reviewer's Guide by Sourcery

This pull request adds an example of using np.fromfile to the slides and updates the benchmark results for np.save, np.load, np.memmap, and np.fromfile. The np.fromfile example includes a code snippet demonstrating its usage, along with a verification step to check the loaded data's shape and dtype. The benchmark results were updated by running the code cells and copying the output.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added np.fromfile example to the slides.
  • Added a markdown cell introducing np.fromfile.
  • Added a code cell demonstrating the usage of np.fromfile with timeit.
  • Added a markdown cell recommending verification of loaded data.
  • Added a code cell to verify the shape and dtype of the loaded data.
source-code/numpy/io_performance.ipynb
Updated benchmark results for np.save, np.load, np.memmap, and np.fromfile.
  • Updated the time reported by the %time magic command for np.save.
  • Updated the time reported by the %timeit magic command for np.load.
  • Updated the time reported by the %timeit magic command for np.fromfile.
  • Updated the time reported by the %time magic command for np.memmap.
  • Updated the time reported by the %timeit magic command for np.memmap.
  • Updated the time reported by the %timeit magic command for np.save.
source-code/numpy/io_performance.ipynb

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@gjbex
gjbex merged commit 59b91d9 into master Apr 3, 2025

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @gjbex - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief explanation of the difference between np.save and np.fromfile.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant