Init() cleanly after Close() #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe a call to DefaultEvtStream.ResetHandles() or similar is needed, but I couldn't find a test case where that was the case... |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not the greatest or most beautiful solution to #100, but it does the job.
It's basically saying: "Hey, Garbage Collector, take care of cleaning up for me, will ya?"
Any improvements are welcome, but I've tried freeing up pretty much everything in DefaultEvtStream to avoid discarding it like a madman, yet it seems that the Handles never get properly freed (probably due to my lack of understanding of the system).