Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf export (RTL issue) #698

Open
shehabsyr opened this issue Mar 31, 2020 · 2 comments
Open

pdf export (RTL issue) #698

shehabsyr opened this issue Mar 31, 2020 · 2 comments
Labels
enhancement topic: import\export

Comments

@shehabsyr
Copy link

shehabsyr commented Mar 31, 2020 •
edited
Loading

writing using RTL language inside the app is great, but everything becomes LTR on pdf export, it will be great if that can be fixed.
thank you for your time.
@Man-with-Arrow
Copy link

Man-with-Arrow commented Jun 16, 2021 •
edited
Loading

Seconded. As far as I can remember (I've used Cherrytree for the last five years or so) this hasn't ever worked properly. @txe, any input on this? Or pointers on where to look to attempt a fix?

Edit: A quick look shows that HTML export is also broken (i.e. LTR instead of RTL). Adding dir=rtl to the exported HTML's <head> makes the whole file RTL, and breaks LTR paragraphs. A solution would be to add the dir attribute to each paragraph on export, according to the detected alignment in Cherrytree itself.

@Man-with-Arrow
Copy link

Almost a year later, this still hasn't been fixed. Behaviour is identical to what I described. @txe and @giuspen , would you mind taking a look here? I'd fix it myself but I'm still early in my studies. I look forward to contributing in the future!

giuspen added a commit that referenced this issue May 22, 2022
@giuspen
support RTL in export to html (#2044, #1668, #698)
c3834b7
giuspen added a commit that referenced this issue May 25, 2022
@giuspen
working on support for RTL (right to left languages) in export to html (
159bf5e 
#2044, #1668, #698) - added dependency to libfribidi
giuspen added a commit that referenced this issue Jun 3, 2022
@giuspen
working on support for RTL (right to left languages) in export to html (
970e47c 
#2044, #1668, #698) - ensuring all tags closed before newline
giuspen added a commit that referenced this issue Jun 4, 2022
@giuspen
working on support for RTL (right to left languages) in export to html (
8d7eac5 
#2044, #1668, #698) - using <p></p> rather than <br/>
giuspen added a commit that referenced this issue Jun 4, 2022
@giuspen
completed support for RTL (right to left languages) in export to html (…
446f5cc 
…#2044, #1668, #698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement topic: import\export
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@txe @Man-with-Arrow @shehabsyr