Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slow find by node name since updating to 1.0.4 #2408

Closed
metal450 opened this issue Dec 18, 2023 · 9 comments
Closed

Very slow find by node name since updating to 1.0.4 #2408

metal450 opened this issue Dec 18, 2023 · 9 comments

Comments

@metal450
Copy link
Contributor

On both Windows & Linux, since updating from 1.0.2 to 1.0.4, searching by node name has become very noticeably slower. Previously it would find the node more or less instantly (you type Ctrl+T, type the name, hit enter, and the result window pops up more or less instantly). Now after hitting enter it goes through a lengthy progressbar, more similar to as if I were searching through full node content. After the first time I search by node name it does seem to be a bit faster during follow-up searches, but previously, I never had to wait for search by node name at all.

Using a "multiple files" db. Tree size is 1559 nodes.

@giuspen
Copy link
Owner

giuspen commented Dec 18, 2023

Thanks for reporting @metal450 I understand, this has been caused by the additional checks that I introduced to support losing access to the open document without crashing.
I can certainly optimise when only searching for node name and tags so restore the previous speed. I'll get back.

giuspen added a commit that referenced this issue Dec 21, 2023
@giuspen
Copy link
Owner

giuspen commented Dec 22, 2023

I should have fixed this and the speed of searching in nodes names only should be again as before v1.0.2.
I can create 1-2 packages for you if you wish to try yourself

@metal450
Copy link
Contributor Author

If you'd like me to test, sure, happy to. If you're just doing it for my benefit, no worries - I rolled back to 1.0.2, so I can just wait until the next release, assuming it isn't super far off :)

@giuspen
Copy link
Owner

giuspen commented Dec 23, 2023

Cheers @metal450 - the next release 1.1.0 will be in 1 to 2 months unless critical issues are found - in that case I will issue 1.0.5 earlier

@metal450
Copy link
Contributor Author

Sounds good!

@metal450
Copy link
Contributor Author

Just updated to 1.1.0; Ctrl+T now never returns any results (it always says 0 matches).

@giuspen
Copy link
Owner

giuspen commented Mar 22, 2024

Sorry about that I will release a fix in a few days

@giuspen
Copy link
Owner

giuspen commented Mar 23, 2024

This should be now fixed. If you could try the test build from https://www.giuspen.net/cherrytree/#testing (called 1.1.0+5) and report if that works as expected or still has issues it would be very useful

@metal450
Copy link
Contributor Author

Yup, search works as expected :)

Just one small observation: there seems to be a new graphical glitch thing - upon the search finishing, there's a strange bar across the bottom of the notes area. It disappears as soon as you focus in the text area, change to another search result, or do anything really. Like this:
2024-03-23 18 17 52

Functionally though, it's back in order :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants