Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is very very slow on searching 4000 subnodes/nodes with text has been added #2019

Closed
goodev2021 opened this issue Apr 11, 2022 · 5 comments

Comments

@goodev2021
Copy link

Hi,

I have imported 4000 text files- each one of 250 kb which comes around 1GB of text content

Searching for a keyword in the entire node takes several minutes.

Is it possible to fetch up the first 10 or 100 results in less than a second and do some pagination if possible.

Thanks

@datavectors
Copy link

I would try ripgrep as an external supplementary search tool.

@giuspen
Copy link
Owner

giuspen commented Sep 16, 2023

I improved the speed of searching/replacing with 'all matches' option, but I still need to decide something about the case where the all matches dialog is then populated by a huge number of results.
A user sent me privately a test cherrytree that has so many hits that at the time of populating the all matches dialog it crashes.
I'll do a pagination inside of the dialog with a maximum number of items per page and load only one page at a time, this should fix the issue. I'll update here on the status.

@giuspen
Copy link
Owner

giuspen commented Sep 19, 2023

I completed the implementation of multi pages support in the all matches dialog with a limit of 50 and I believe the result is pretty good so closing this ticket for now, I'll probably issue a new version 1.0.2 in the next few days

@giuspen giuspen closed this as completed Sep 19, 2023
@LucasSchelkes-BA
Copy link

The search is super fast now in 1.0.2 🚀 Thanks a lot, huge improvement 💯

@giuspen
Copy link
Owner

giuspen commented Sep 27, 2023

Thanks for the feedback @LucasSchelkes-BA ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants