feat(cli): add the ability to specify a custom keybinding/symbols file via the cli #2731
Conversation
0x61nas
force-pushed
the
feat/custom-configs-path
branch
from
c678978 to
5a14779
Compare
cruessler
left a comment
cruessler
left a comment
There was a problem hiding this comment.
I checked the PR locally, I didn’t find any issues. There’s just a few suggestions for refactoring and a typo.
cruessler
left a comment
cruessler
left a comment
There was a problem hiding this comment.
I didn’t mean to approve just yet, this was by mistake.
|
@0x61nas will move this to the next release |
|
sorry I got busy with life issues:(, I will try to get it done by tomorrow |
0x61nas
force-pushed
the
feat/custom-configs-path
branch
from
942b3c4 to
1339a1d
Compare
cruessler
left a comment
cruessler
left a comment
There was a problem hiding this comment.
Looks good to me! I tested the changes locally, both the symbols as well as the key bindings were loaded when I started gitui this way: cargo run -- --key-symbols ./key_symbols.ron --key-bindings key_bindings.ron. When the files were not present or when they were malformed, gitui would fall back to the defaults. Thanks a lot!
|
@0x61nas last thing we need is a changelog entry |
|
okie |
…e via the cli Introduce `-k`,`--key-bindings`, `-s`, and `--key-symbols` arguments to allow the user from specifying a custom config files without having to change the global ones this change is meant to address github issue: gitui-org#2714
0x61nas
force-pushed
the
feat/custom-configs-path
branch
from
1339a1d to
6cf2bf5
Compare
3 participants
Introduce
-k,--key-bindings,-s, and--key-symbolsarguments to allow the user from specifying a custom config files without having to change the global onesThis Pull Request fixes/closes #2714.
It changes the following:
I followed the checklist:
make checkwithout errors