Skip to content

feat: support 'n'/'p' key to move to the next/prev hunk. #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
extrawurst merged 3 commits into from
Jun 19, 2023
Merged

feat: support 'n'/'p' key to move to the next/prev hunk. #1723

extrawurst merged 3 commits into from
Jun 19, 2023

Conversation

@hamflx
Copy link
Contributor

@hamflx hamflx commented Jun 17, 2023 •
edited by extrawurst
Loading

This Pull Request fixes/closes #1523.

It changes the following:

  • add 'n'/'p' key for DiffComponent
  • add #[allow(clippy::too_many_lines)] for DiffComponent::event

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

extrawurst
extrawurst requested changes Jun 19, 2023
View reviewed changes
@extrawurst extrawurst merged commit bfcf33f into gitui-org:master Jun 19, 2023
IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
@hamflx @IndianBoy42
feat: support 'n'/'p' key to move to the next/prev hunk. (gitui-org#1723
a0cfaab 
)

* feat: support 'n'/'p' key to move to the next/prev hunk.
* feat: auto scroll next/prev hunk into visible area.
* add unittest for VerticalScroll::move_area_to_visible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@extrawurst extrawurst extrawurst requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new feature for scrolling to prev/next hunk, not just next line

2 participants

@hamflx @extrawurst