husky pre-commit hooks not run

[stephanweissenberger]

Describe the bug
With husky I added a precommit hook to build my project before commiting it.
git commit does respect this and builds my project prior to commit.
gitui commit does not.

To Reproduce
Steps to reproduce the behavior:

1. Add a precommit hook
2. Commit via CLI to verify the precommit hook is working
3. Commit via gitui
4. precommit hook is not executed

Expected behavior
A precommit hook should be respected by gitui

Context (please complete the following information):

• OS/Distro + Version: [Windows 21H1]
• GitUI Version [0.18.0]

[extrawurst]

please run with logging gitui -l and share the logs

[stephanweissenberger]

06:28:38 [TRACE] (1) gitui::app: [src\app.rs:358] update
06:28:38 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 8093369622771005831] (type: WorkingDir)
06:28:38 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 27492516042608446] (type: Stage)
06:28:38 [TRACE] (3) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 27492516042608446 (type: Stage)
06:28:38 [TRACE] (2) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 8093369622771005831 (type: WorkingDir)
06:28:38 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Resize(187, 54))
06:28:38 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:39 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:40 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Down, modifiers: NONE }))
06:28:40 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: WorkDir, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:40 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:40 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: WorkDir, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:41 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Enter, modifiers: NONE }))
06:28:41 [TRACE] (1) gitui::app: [src\app.rs:358] update
06:28:41 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: WorkDir, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:41 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 17467022224256997398] (type: WorkingDir)
06:28:41 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 13870839505501950219] (type: Stage)
06:28:41 [TRACE] (4) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 13870839505501950219 (type: Stage)
06:28:41 [TRACE] (3) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 17467022224256997398 (type: WorkingDir)
06:28:41 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:41 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:41 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:42 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Down, modifiers: NONE }))
06:28:42 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: Stage, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:42 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:42 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: Stage, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:43 [TRACE] (1) gitui::app: [src\app.rs:358] update
06:28:43 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: Stage, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:43 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 11325537580545616272] (type: WorkingDir)
06:28:43 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 5125050458315069150] (type: Stage)
06:28:43 [TRACE] (4) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 5125050458315069150 (type: Stage)
06:28:43 [TRACE] (3) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 11325537580545616272 (type: WorkingDir)
06:28:43 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:44 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:44 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:44 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('c'), modifiers: NONE }))
06:28:46 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('a'), modifiers: NONE }))
06:28:47 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('n'), modifiers: NONE }))
06:28:47 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('o'), modifiers: NONE }))
06:28:47 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('t'), modifiers: NONE }))
06:28:47 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('h'), modifiers: NONE }))
06:28:47 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('e'), modifiers: NONE }))
06:28:48 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('r'), modifiers: NONE }))
06:28:48 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char(' '), modifiers: NONE }))
06:28:48 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('c'), modifiers: NONE }))
06:28:48 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('h'), modifiers: NONE }))
06:28:48 [TRACE] (1) gitui::app: [src\app.rs:358] update
06:28:48 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: Stage, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:48 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 13076846175333652500] (type: WorkingDir)
06:28:48 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 6728392064951034947] (type: Stage)
06:28:48 [TRACE] (4) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 6728392064951034947 (type: Stage)
06:28:48 [TRACE] (3) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 13076846175333652500 (type: WorkingDir)
06:28:48 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:49 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('a'), modifiers: NONE }))
06:28:49 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:49 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:49 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('n'), modifiers: NONE }))
06:28:49 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('g'), modifiers: NONE }))
06:28:49 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('e'), modifiers: NONE }))
06:28:50 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Enter, modifiers: NONE }))
06:28:50 [TRACE] (1) gitui::app: [src\app.rs:358] update
06:28:50 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: Stage, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:50 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 17759465892022646311] (type: WorkingDir)
06:28:50 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 1268490788371977227] (type: Stage)
06:28:50 [TRACE] (4) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 1268490788371977227 (type: Stage)
06:28:50 [TRACE] (3) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 17759465892022646311 (type: WorkingDir)
06:28:51 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:51 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:51 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:53 [TRACE] (1) gitui::app: [src\app.rs:358] update
06:28:53 [TRACE] (1) asyncgit::diff: [asyncgit\src\diff.rs:93] request DiffParams { path: "xxx.cs", diff_type: Stage, options: DiffOptions { ignore_whitespace: false, context: 3, interhunk_lines: 0 } }
06:28:53 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 10245235635540339689] (type: WorkingDir)
06:28:53 [TRACE] (1) asyncgit::status: [asyncgit\src\status.rs:95] request: [hash: 8734810998434222429] (type: Stage)
06:28:53 [TRACE] (4) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 8734810998434222429 (type: Stage)
06:28:53 [TRACE] (3) asyncgit::status: [asyncgit\src\status.rs:151] status fetched: 10245235635540339689 (type: WorkingDir)
06:28:54 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Diff)
06:28:54 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:54 [TRACE] (1) gitui::app: [src\app.rs:377] update_async: Git(Status)
06:28:54 [TRACE] (1) gitui::app: [src\app.rs:286] event: Input(Key(KeyEvent { code: Char('c'), modifiers: CONTROL }))
06:28:54 [ERROR] input thread error: sending on a disconnected channel

[extrawurst]

Can you share the precommit?

[stephanweissenberger]

I adopted my pre-commit hook to be more universal and always return an error.
Given that you use husky.
This will always return errorcode 1.

npx husky add .husky/pre-commit "exit 1"
git add .husky/pre-commit

[stephanweissenberger]

Looks like git2 doesnt support that, at least i found nothing documented, telling me otherwise...

Line 63:
https://github.com/extrawurst/gitui/blob/master/asyncgit/src/sync/commit.rs

[extrawurst]

no libgit2/git2-rs are not of help here anyway. we implement them in here ourselves.
so we only support commit-msg and post-commit for now

edit: we actually support it, stupid me

[extrawurst]

@stephanweissenberger I am not using husky, never have. I need to know what kind of .git/hooks/pre-commit file it generates to be able to look into this