2.0.5: gitdb.test.db.test_git.TestGitDB, gitdb.test.db.test_ref.TestReferenceDB, gitdb.test.performance.test_pack_streaming.TestPackStreamingPerformance fail #51

Activity

1. Byron commented on Aug 28, 2019

   

   Byron

   on Aug 28, 2019

   Member

   More actions

   As in GitPython, an initialised git repository along with some history are assumed for the tests to run successfully.
   When looking at the (freshly run) tests on CI, I see the performance tests are skipped there. This might be as they are known to fail on travis as it does check out the repository with low history depth (even though 1000 seems high enough).

   I don't think the performance tests are testing anything new or add to coverage, which is why you could skip them as well.

   For the other two non-performance failures, there might just not be enough history. If git init . does not create a single commit, then there is no reference either. Please make sure there is some history.

   Apologies for the inconvenience, it's clear that unit tests should be isolated and not depend on any state they don't control themselves.

   Please let me know if this helped, or if there are any further questions.
2. dvzrv commented on Sep 28, 2019

   

   dvzrv

   on Sep 28, 2019

   Author

   More actions

   Why not create a git repository on the fly as an asset?
   That kind of decoupling would be really great!
3. dvzrv commented on Sep 29, 2019

   

   dvzrv

   on Sep 29, 2019

   Author

   More actions

   This at least works for nearly all tests:

     local TEST_TMPDIR=$(mktemp -d)
     (
       cd "$TEST_TMPDIR"
       git init
       git config user.name "Test User"
       git config user.email "test@user.org"
       for commit in {1..50}; do
         touch "file${commit}"
         git add "file${commit}"
         git commit -m "file${commit}"
       done
     )
     export GITDB_TEST_GIT_REPO_BASE="${TEST_TMPDIR}/.git"
     nosetests -vd -e 'test_pack_writing'
   
4. Byron

   added

   acknowledged

   on Sep 29, 2019
5. Byron commented on Sep 29, 2019

   

   Byron

   on Sep 29, 2019

   Member

   More actions

   That looks neat! Do you think you could supply this with a PR? Thanks so much!
6. dvzrv commented on Sep 29, 2019

   

   dvzrv

   on Sep 29, 2019

   Author

   More actions

   @Byron I guess it depends on what you understand under pull request.
   As part of the test suite (have mainly worked with pytest actually), or as part of the travis setup?
7. Byron commented on Sep 30, 2019

   

   Byron

   on Sep 30, 2019

   Member

   More actions

   I think Travis could call a script which contains that code. If I remember correctly, one can set an environment variable for the repository it should use for tests. @dvzrv