This repository was archived by the owner on Apr 14, 2024. It is now read-only.
remove unused lines that break python 3.x - #6
Merged
Conversation
Closed
Byron
added a commit
that referenced
this pull request
Apr 16, 2014
remove unused lines that break python 3.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have yet to get tests to fully work (trouble importing async.mod.zlib), but these changes remove imports that are not used in the code and break python 3.x. The module new and the threading _Condition go away in python 3.
I know that you say you are not planning on going to python3, but these changes do not hurt python 2.7 and help towards python3.