Skip to content

Support Cygwin's Git on Windows #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 22, 2016
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
tc-helper: fix minor contexlib abuse
  • Loading branch information
ankostis committed Oct 17, 2016
commit cc77e6b2862733a211c55cf29cc7a83c36c27919
7 changes: 3 additions & 4 deletions git/test/lib/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,9 +181,6 @@ def git_daemon_launched(base_path, ip, port):
as_process=True)
# yes, I know ... fortunately, this is always going to work if sleep time is just large enough
time.sleep(0.5 * (1 + is_win))

yield

except Exception as ex:
msg = textwrap.dedent("""
Launching git-daemon failed due to: %s
Expand All @@ -203,8 +200,10 @@ def git_daemon_launched(base_path, ip, port):
CYGWIN has no daemon, but if one exists, it gets along fine (but has also paths problems).""")
log.warning(msg, ex, ip, port, base_path, base_path, exc_info=1)

yield
yield # OK, assume daemon started manually.

else:
yield # Yield outside try, to avoid catching
finally:
if gd:
try:
Expand Down